From 058bda0ee77d505a3194d8b206e8a3157af61dce Mon Sep 17 00:00:00 2001 From: Hardik Shah Date: Thu, 26 Jun 2025 13:54:56 -0700 Subject: [PATCH] fixes --- .github/workflows/integration-vector-io-tests.yml | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/.github/workflows/integration-vector-io-tests.yml b/.github/workflows/integration-vector-io-tests.yml index f2cd0fa4d..29cde1881 100644 --- a/.github/workflows/integration-vector-io-tests.yml +++ b/.github/workflows/integration-vector-io-tests.yml @@ -35,10 +35,8 @@ jobs: with: python-version: ${{ matrix.python-version }} - - name: Setup ollama - uses: ./.github/actions/setup-ollama - - name: Setup Chroma + if: matrix.vector-io-provider == 'remote::chromadb' run: | docker run --rm -d --pull always \ --name chromadb \ @@ -49,6 +47,7 @@ jobs: chromadb/chroma:latest - name: Wait for ChromaDB to be ready + if: matrix.vector-io-provider == 'remote::chromadb' run: | echo "Waiting for ChromaDB to be ready..." for i in {1..30}; do @@ -74,11 +73,10 @@ jobs: - name: Run Vector IO Integration Tests env: - ENABLE_CHROMADB: true - CHROMADB_URL: http://localhost:8000 - OLLAMA_URL: "http://0.0.0.0:11434" + ENABLE_CHROMADB: ${{ matrix.vector-io-provider == 'remote::chromadb' && 'true' || '' }} + CHROMADB_URL: ${{ matrix.vector-io-provider == 'remote::chromadb' && 'http://localhost:8000' || '' }} run: | - uv run pytest -sv --stack-config="inference=ollama,vector_io=${{ matrix.vector-io-provider }}" \ + uv run pytest -sv --stack-config="inference=sentence-transformers,vector_io=${{ matrix.vector-io-provider }}" \ tests/integration/vector_io \ --embedding-model all-MiniLM-L6-v2 @@ -94,7 +92,7 @@ jobs: echo "SANITIZED_PROVIDER=${matrix.vector-io-provider//:/_}" >> $GITHUB_ENV - name: Write ChromaDB logs to file - if: ${{ always() }} + if: ${{ always() && matrix.vector-io-provider == 'remote::chromadb' }} run: | docker logs chromadb > chromadb.log