phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-06-28 10:54:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: loosen tool call checks in inference store

Browse source 
This loosens up the tool call function name and arguments checks in
`tests/integration/inference/test_openai_completion.py::test_inference_store_tool_calls`
because the small models we use in CI cannot reliably get the tool
call function name or arguments exactly right.

Closes #2345

Signed-off-by: Ben Browning <bbrownin@redhat.com>
This commit is contained in:
Ben Browning 2025-06-07 19:47:51 -04:00
parent 28ca00d0d9
commit 06be99f1a2
1 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

10
tests/integration/inference/test_openai_completion.py
View file

@ -372,10 +372,14 @@ def test_inference_store_tool_calls(compat_client, client_with_models, text_mode
) )
assert input_content == message, retrieved_response assert input_content == message, retrieved_response
tool_calls = retrieved_response.choices[0].message.tool_calls tool_calls = retrieved_response.choices[0].message.tool_calls
# sometimes model doesn't ouptut tool calls, but we still want to test that the tool was called # sometimes model doesn't output tool calls, but we still want to test that the tool was called
if tool_calls: if tool_calls:
# because we test with small models, just check that we retrieved
# a tool call with a name and arguments string, but ignore contents
assert len(tool_calls) == 1 assert len(tool_calls) == 1
assert tool_calls[0].function.name == "get_weather" assert tool_calls[0].function.name
assert "tokyo" in tool_calls[0].function.arguments.lower() assert tool_calls[0].function.arguments
else: else:
# failed tool call parses show up as a message with content, so ensure
# that the retrieve response content matches the original request
assert retrieved_response.choices[0].message.content == content assert retrieved_response.choices[0].message.content == content