phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-12-15 17:02:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

minimize change

Browse source
This commit is contained in:
Raghotham Murthy 2025-10-11 01:32:38 -07:00
parent ed78090b8e
commit 06d02bf3de
23 changed files with 161 additions and 197 deletions
Download patch file Download diff file Expand all files Collapse all files

1
tests/unit/files/test_files.py
View file

@ -43,7 +43,6 @@ async def files_provider(tmp_path):
provider = LocalfsFilesImpl(config, default_policy())
await provider.initialize()
yield provider
await provider.shutdown()
@pytest.fixture

1
tests/unit/fixtures.py
View file

@ -18,7 +18,6 @@ async def sqlite_kvstore(tmp_path):
kvstore = SqliteKVStoreImpl(kvstore_config)
await kvstore.initialize()
yield kvstore
await kvstore.close()
@pytest.fixture(scope="function")

2
tests/unit/prompts/prompts/conftest.py
View file

@ -28,5 +28,3 @@ async def temp_prompt_store(tmp_path_factory):
store.kvstore = await kvstore_impl(SqliteKVStoreConfig(db_path=db_path))
yield store
await store.kvstore.close()

3
tests/unit/providers/vector_io/test_vector_io_openai_vector_stores.py
View file

@ -46,9 +46,12 @@ async def test_initialize_index(vector_index):
async def test_add_chunks_query_vector(vector_index, sample_chunks, sample_embeddings):
vector_index.delete()
vector_index.initialize()
await vector_index.add_chunks(sample_chunks, sample_embeddings)
resp = await vector_index.query_vector(sample_embeddings[0], k=1, score_threshold=-1)
assert resp.chunks[0].content == sample_chunks[0].content
vector_index.delete()
async def test_chunk_id_conflict(vector_index, sample_chunks, embedding_dimension):

32
tests/unit/server/test_quota.py
View file

@ -52,21 +52,17 @@ def auth_app(tmp_path, request):
db_path = tmp_path / f"quota_{request.node.name}.db"
quota = build_quota_config(db_path)
quota_middleware = QuotaMiddleware(
inner_app,
kv_config=quota.kvstore,
anonymous_max_requests=quota.anonymous_max_requests,
authenticated_max_requests=quota.authenticated_max_requests,
window_seconds=86400,
app = InjectClientIDMiddleware(
QuotaMiddleware(
inner_app,
kv_config=quota.kvstore,
anonymous_max_requests=quota.anonymous_max_requests,
authenticated_max_requests=quota.authenticated_max_requests,
window_seconds=86400,
),
client_id=f"client_{request.node.name}",
)
app = InjectClientIDMiddleware(quota_middleware, client_id=f"client_{request.node.name}")
yield app
# Cleanup
import asyncio
asyncio.run(quota_middleware.close())
return app
def test_authenticated_quota_allows_up_to_limit(auth_app):
@ -85,8 +81,6 @@ def test_authenticated_quota_blocks_after_limit(auth_app):
def test_anonymous_quota_allows_up_to_limit(tmp_path, request):
import asyncio
inner_app = FastAPI()
@inner_app.get("/test")
@ -107,12 +101,8 @@ def test_anonymous_quota_allows_up_to_limit(tmp_path, request):
client = TestClient(app)
assert client.get("/test").status_code == 200
asyncio.run(app.close())
def test_anonymous_quota_blocks_after_limit(tmp_path, request):
import asyncio
inner_app = FastAPI()
@inner_app.get("/test")
@ -135,5 +125,3 @@ def test_anonymous_quota_blocks_after_limit(tmp_path, request):
resp = client.get("/test")
assert resp.status_code == 429
assert resp.json()["error"]["message"] == "Quota exceeded"
asyncio.run(app.close())

10
tests/unit/utils/inference/test_inference_store.py
View file

@ -89,8 +89,6 @@ async def test_inference_store_pagination_basic():
assert result3.data[0].id == "zebra-task"
assert result3.has_more is False
await store.sql_store.close()
async def test_inference_store_pagination_ascending():
"""Test pagination with ascending order."""
@ -128,8 +126,6 @@ async def test_inference_store_pagination_ascending():
assert result2.data[0].id == "charlie-task"
assert result2.has_more is True
await store.sql_store.close()
async def test_inference_store_pagination_with_model_filter():
"""Test pagination combined with model filtering."""
@ -170,8 +166,6 @@ async def test_inference_store_pagination_with_model_filter():
assert result2.data[0].model == "model-a"
assert result2.has_more is False
await store.sql_store.close()
async def test_inference_store_pagination_invalid_after():
"""Test error handling for invalid 'after' parameter."""
@ -184,8 +178,6 @@ async def test_inference_store_pagination_invalid_after():
with pytest.raises(ValueError, match="Record with id='non-existent' not found in table 'chat_completions'"):
await store.list_chat_completions(after="non-existent", limit=2)
await store.sql_store.close()
async def test_inference_store_pagination_no_limit():
"""Test pagination behavior when no limit is specified."""
@ -216,5 +208,3 @@ async def test_inference_store_pagination_no_limit():
assert result.data[0].id == "beta-second" # Most recent first
assert result.data[1].id == "omega-first"
assert result.has_more is False
await store.sql_store.close()

16
tests/unit/utils/responses/test_responses_store.py
View file

@ -98,8 +98,6 @@ async def test_responses_store_pagination_basic():
assert result3.data[0].id == "zebra-resp"
assert result3.has_more is False
await store.sql_store.close()
async def test_responses_store_pagination_ascending():
"""Test pagination with ascending order."""
@ -138,8 +136,6 @@ async def test_responses_store_pagination_ascending():
assert result2.data[0].id == "charlie-resp"
assert result2.has_more is True
await store.sql_store.close()
async def test_responses_store_pagination_with_model_filter():
"""Test pagination combined with model filtering."""
@ -181,8 +177,6 @@ async def test_responses_store_pagination_with_model_filter():
assert result2.data[0].model == "model-a"
assert result2.has_more is False
await store.sql_store.close()
async def test_responses_store_pagination_invalid_after():
"""Test error handling for invalid 'after' parameter."""
@ -195,8 +189,6 @@ async def test_responses_store_pagination_invalid_after():
with pytest.raises(ValueError, match="Record with id.*'non-existent' not found in table 'openai_responses'"):
await store.list_responses(after="non-existent", limit=2)
await store.sql_store.close()
async def test_responses_store_pagination_no_limit():
"""Test pagination behavior when no limit is specified."""
@ -229,8 +221,6 @@ async def test_responses_store_pagination_no_limit():
assert result.data[1].id == "omega-resp"
assert result.has_more is False
await store.sql_store.close()
async def test_responses_store_get_response_object():
"""Test retrieving a single response object."""
@ -259,8 +249,6 @@ async def test_responses_store_get_response_object():
with pytest.raises(ValueError, match="Response with id non-existent not found"):
await store.get_response_object("non-existent")
await store.sql_store.close()
async def test_responses_store_input_items_pagination():
"""Test pagination functionality for input items."""
@ -342,8 +330,6 @@ async def test_responses_store_input_items_pagination():
with pytest.raises(ValueError, match="Cannot specify both 'before' and 'after' parameters"):
await store.list_response_input_items("test-resp", before="some-id", after="other-id")
await store.sql_store.close()
async def test_responses_store_input_items_before_pagination():
"""Test before pagination functionality for input items."""
@ -404,5 +390,3 @@ async def test_responses_store_input_items_before_pagination():
ValueError, match="Input item with id 'non-existent' not found for response 'test-resp-before'"
):
await store.list_response_input_items("test-resp-before", before="non-existent")
await store.sql_store.close()

17
tests/unit/utils/sqlstore/test_sqlstore.py
View file

@ -64,9 +64,6 @@ async def test_sqlite_sqlstore():
assert result.data == [{"id": 12, "name": "test12"}]
assert result.has_more is False
# cleanup
await sqlstore.close()
async def test_sqlstore_pagination_basic():
"""Test basic pagination functionality at the SQL store level."""
@ -131,8 +128,6 @@ async def test_sqlstore_pagination_basic():
assert result3.data[0]["id"] == "zebra"
assert result3.has_more is False
await store.close()
async def test_sqlstore_pagination_with_filter():
"""Test pagination with WHERE conditions."""
@ -185,8 +180,6 @@ async def test_sqlstore_pagination_with_filter():
assert result2.data[0]["id"] == "xyz"
assert result2.has_more is False
await store.close()
async def test_sqlstore_pagination_ascending_order():
"""Test pagination with ascending order."""
@ -235,8 +228,6 @@ async def test_sqlstore_pagination_ascending_order():
assert result2.data[0]["id"] == "alpha"
assert result2.has_more is True
await store.close()
async def test_sqlstore_pagination_multi_column_ordering_error():
"""Test that multi-column ordering raises an error when using cursor pagination."""
@ -274,8 +265,6 @@ async def test_sqlstore_pagination_multi_column_ordering_error():
assert len(result.data) == 1
assert result.data[0]["id"] == "task1"
await store.close()
async def test_sqlstore_pagination_cursor_requires_order_by():
"""Test that cursor pagination requires order_by parameter."""
@ -293,8 +282,6 @@ async def test_sqlstore_pagination_cursor_requires_order_by():
cursor=("id", "task1"),
)
await store.close()
async def test_sqlstore_pagination_error_handling():
"""Test error handling for invalid columns and cursor IDs."""
@ -427,8 +414,6 @@ async def test_where_operator_edge_cases():
with pytest.raises(ValueError, match="Unsupported operator"):
await store.fetch_all("events", where={"ts": {"!=": base}})
await store.close()
async def test_sqlstore_pagination_custom_key_column():
"""Test pagination with custom primary key column (not 'id')."""
@ -478,5 +463,3 @@ async def test_sqlstore_pagination_custom_key_column():
assert len(result2.data) == 1
assert result2.data[0]["uuid"] == "uuid-alpha"
assert result2.has_more is False
await store.close()

6
tests/unit/utils/test_authorized_sqlstore.py
View file

@ -77,8 +77,6 @@ async def test_authorized_fetch_with_where_sql_access_control(mock_get_authentic
assert row is not None
assert row["title"] == "User Document"
await base_sqlstore.close()
@patch("llama_stack.providers.utils.sqlstore.authorized_sqlstore.get_authenticated_user")
async def test_sql_policy_consistency(mock_get_authenticated_user):
@ -165,8 +163,6 @@ async def test_sql_policy_consistency(mock_get_authenticated_user):
f"Difference: SQL only: {sql_ids - policy_ids}, Policy only: {policy_ids - sql_ids}"
)
await base_sqlstore.close()
@patch("llama_stack.providers.utils.sqlstore.authorized_sqlstore.get_authenticated_user")
async def test_authorized_store_user_attribute_capture(mock_get_authenticated_user):
@ -215,5 +211,3 @@ async def test_authorized_store_user_attribute_capture(mock_get_authenticated_us
# Third item should have null attributes (no authenticated user)
assert result.data[2]["id"] == "item3"
assert result.data[2]["access_attributes"] is None
await base_sqlstore.close()