phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-06-27 18:50:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: chat completion with more than one choice (#2288)
Some checks failed
Integration Tests / test-matrix (http, inference) (push) Failing after 13s
Details
Integration Tests / test-matrix (library, datasets) (push) Failing after 12s
Details
Integration Tests / test-matrix (library, providers) (push) Failing after 9s
Details
Unit Tests / unit-tests (3.10) (push) Failing after 9s
Details
Unit Tests / unit-tests (3.12) (push) Failing after 1m33s
Details
Integration Auth Tests / test-matrix (oauth2_token) (push) Failing after 8s
Details
Integration Tests / test-matrix (library, agents) (push) Failing after 11s
Details
Integration Tests / test-matrix (http, providers) (push) Failing after 13s
Details
Integration Tests / test-matrix (library, scoring) (push) Failing after 10s
Details
Unit Tests / unit-tests (3.13) (push) Failing after 9s
Details
Integration Tests / test-matrix (http, datasets) (push) Failing after 10s
Details
Integration Tests / test-matrix (http, post_training) (push) Failing after 13s
Details
Integration Tests / test-matrix (library, inference) (push) Failing after 11s
Details
Integration Tests / test-matrix (library, tool_runtime) (push) Failing after 9s
Details
Update ReadTheDocs / update-readthedocs (push) Failing after 7s
Details
Integration Tests / test-matrix (http, agents) (push) Failing after 11s
Details
Integration Tests / test-matrix (http, inspect) (push) Failing after 10s
Details
Integration Tests / test-matrix (http, scoring) (push) Failing after 10s
Details
Integration Tests / test-matrix (library, inspect) (push) Failing after 10s
Details
Integration Tests / test-matrix (library, post_training) (push) Failing after 10s
Details
Test External Providers / test-external-providers (venv) (push) Failing after 8s
Details
Integration Tests / test-matrix (http, tool_runtime) (push) Failing after 10s
Details
Unit Tests / unit-tests (3.11) (push) Failing after 8s
Details
Pre-commit / pre-commit (push) Successful in 3m18s
Details

Browse source 
# What does this PR do?
Fix a bug in openai_compat where choices are not indexed correctly.

## Test Plan
Added a new test.

Rerun the failed inference_store tests:
llama stack run fireworks --image-type conda
pytest -s -v tests/integration/ --stack-config http://localhost:8321 -k
'test_inference_store' --text-model meta-llama/Llama-3.3-70B-Instruct
--count 10
This commit is contained in:
ehhuang 2025-05-27 15:39:15 -07:00 • committed by GitHub
parent 1d46f3102e
commit 0b695538af
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 53 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

4
llama_stack/providers/utils/inference/openai_compat.py
View file

@ -1402,9 +1402,8 @@ class OpenAIChatCompletionToLlamaStackMixin:
outstanding_responses: list[Awaitable[AsyncIterator[ChatCompletionResponseStreamChunk]]],
):
id = f"chatcmpl-{uuid.uuid4()}"
for outstanding_response in outstanding_responses:
for i, outstanding_response in enumerate(outstanding_responses):
response = await outstanding_response
i = 0
async for chunk in response:
event = chunk.event
finish_reason = _convert_stop_reason_to_openai_finish_reason(event.stop_reason)
@ -1459,7 +1458,6 @@ class OpenAIChatCompletionToLlamaStackMixin:
model=model,
object="chat.completion.chunk",
)
i = i + 1
async def _process_non_stream_response(
self, model: str, outstanding_responses: list[Awaitable[ChatCompletionResponse]]