phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-08-15 06:00:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: make provider_id a required field in vector DB registration

Browse source
This commit is contained in:
Habeb Nawatha 2025-08-14 17:09:59 +03:00
parent 46ff302d87
commit 121a8584d6
2 changed files with 2 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
llama_stack/apis/vector_dbs/vector_dbs.py
View file

@ -90,8 +90,8 @@ class VectorDBs(Protocol):
self, self,
vector_db_id: str, vector_db_id: str,
embedding_model: str, embedding_model: str,
provider_id: str,
embedding_dimension: int | None = 384, embedding_dimension: int | None = 384,
provider_id: str | None = None,
vector_db_name: str | None = None, vector_db_name: str | None = None,
provider_vector_db_id: str | None = None, provider_vector_db_id: str | None = None,
) -> VectorDB: ) -> VectorDB:

11
llama_stack/core/routing_tables/vector_dbs.py
View file

@ -47,21 +47,12 @@ class VectorDBsRoutingTable(CommonRoutingTableImpl, VectorDBs):
self, self,
vector_db_id: str, vector_db_id: str,
embedding_model: str, embedding_model: str,
provider_id: str,
embedding_dimension: int | None = 384, embedding_dimension: int | None = 384,
provider_id: str | None = None,
provider_vector_db_id: str | None = None, provider_vector_db_id: str | None = None,
vector_db_name: str | None = None, vector_db_name: str | None = None,
) -> VectorDB: ) -> VectorDB:
provider_vector_db_id = provider_vector_db_id or vector_db_id provider_vector_db_id = provider_vector_db_id or vector_db_id
if provider_id is None:
if len(self.impls_by_provider_id) > 0:
provider_id = list(self.impls_by_provider_id.keys())[0]
if len(self.impls_by_provider_id) > 1:
logger.warning(
f"No provider specified and multiple providers available. Arbitrarily selected the first provider {provider_id}."
)
else:
raise ValueError("No provider available. Please configure a vector_io provider.")
model = await lookup_model(self, embedding_model) model = await lookup_model(self, embedding_model)
if model is None: if model is None:
raise ModelNotFoundError(embedding_model) raise ModelNotFoundError(embedding_model)