mirror of
https://github.com/meta-llama/llama-stack.git
synced 2025-07-02 20:40:36 +00:00
feat: add responses input items api (#2239)
# What does this PR do? TSIA ## Test Plan added integration and unit tests
This commit is contained in:
parent
055f48b6a2
commit
15b0a67555
9 changed files with 546 additions and 12 deletions
|
@ -3,11 +3,7 @@
|
|||
#
|
||||
# This source code is licensed under the terms described in the LICENSE file in
|
||||
# the root directory of this source tree.
|
||||
|
||||
from urllib.parse import urljoin
|
||||
|
||||
import pytest
|
||||
import requests
|
||||
from openai import OpenAI
|
||||
|
||||
from llama_stack.distribution.library_client import LlamaStackAsLibraryClient
|
||||
|
@ -80,11 +76,10 @@ def test_responses_store(openai_client, client_with_models, text_model_id, strea
|
|||
if not tools:
|
||||
content = response.output[0].content[0].text
|
||||
|
||||
# list responses is not available in the SDK
|
||||
url = urljoin(str(client.base_url), "responses")
|
||||
response = requests.get(url, headers={"Authorization": f"Bearer {client.api_key}"})
|
||||
assert response.status_code == 200
|
||||
data = response.json()["data"]
|
||||
# list responses - use the underlying HTTP client for endpoints not in SDK
|
||||
list_response = client._client.get("/responses")
|
||||
assert list_response.status_code == 200
|
||||
data = list_response.json()["data"]
|
||||
assert response_id in [r["id"] for r in data]
|
||||
|
||||
# test retrieve response
|
||||
|
@ -95,3 +90,133 @@ def test_responses_store(openai_client, client_with_models, text_model_id, strea
|
|||
assert retrieved_response.output[0].type == "function_call"
|
||||
else:
|
||||
assert retrieved_response.output[0].content[0].text == content
|
||||
|
||||
|
||||
def test_list_response_input_items(openai_client, client_with_models, text_model_id):
|
||||
"""Test the new list_openai_response_input_items endpoint."""
|
||||
if isinstance(client_with_models, LlamaStackAsLibraryClient):
|
||||
pytest.skip("OpenAI responses are not supported when testing with library client yet.")
|
||||
|
||||
client = openai_client
|
||||
message = "What is the capital of France?"
|
||||
|
||||
# Create a response first
|
||||
response = client.responses.create(
|
||||
model=text_model_id,
|
||||
input=[
|
||||
{
|
||||
"role": "user",
|
||||
"content": message,
|
||||
}
|
||||
],
|
||||
stream=False,
|
||||
)
|
||||
|
||||
response_id = response.id
|
||||
|
||||
# Test the new list input items endpoint
|
||||
input_items_response = client.responses.input_items.list(response_id=response_id)
|
||||
|
||||
# Verify the structure follows OpenAI API spec
|
||||
assert input_items_response.object == "list"
|
||||
assert hasattr(input_items_response, "data")
|
||||
assert isinstance(input_items_response.data, list)
|
||||
assert len(input_items_response.data) > 0
|
||||
|
||||
# Verify the input item contains our message
|
||||
input_item = input_items_response.data[0]
|
||||
assert input_item.type == "message"
|
||||
assert input_item.role == "user"
|
||||
assert message in str(input_item.content)
|
||||
|
||||
|
||||
def test_list_response_input_items_with_limit_and_order(openai_client, client_with_models, text_model_id):
|
||||
"""Test the list input items endpoint with limit and order parameters."""
|
||||
if isinstance(client_with_models, LlamaStackAsLibraryClient):
|
||||
pytest.skip("OpenAI responses are not supported when testing with library client yet.")
|
||||
|
||||
client = openai_client
|
||||
|
||||
# Create a response with multiple input messages to test limit and order
|
||||
# Use distinctive content to make order verification more reliable
|
||||
messages = [
|
||||
{"role": "user", "content": "Message A: What is the capital of France?"},
|
||||
{"role": "assistant", "content": "The capital of France is Paris."},
|
||||
{"role": "user", "content": "Message B: What about Spain?"},
|
||||
{"role": "assistant", "content": "The capital of Spain is Madrid."},
|
||||
{"role": "user", "content": "Message C: And Italy?"},
|
||||
]
|
||||
|
||||
response = client.responses.create(
|
||||
model=text_model_id,
|
||||
input=messages,
|
||||
stream=False,
|
||||
)
|
||||
|
||||
response_id = response.id
|
||||
|
||||
# First get all items to establish baseline
|
||||
all_items_response = client.responses.input_items.list(response_id=response_id)
|
||||
assert all_items_response.object == "list"
|
||||
total_items = len(all_items_response.data)
|
||||
assert total_items == 5 # Should have all 5 input messages
|
||||
|
||||
# Test 1: Limit parameter - request only 2 items
|
||||
limited_response = client.responses.input_items.list(response_id=response_id, limit=2)
|
||||
assert limited_response.object == "list"
|
||||
assert len(limited_response.data) == min(2, total_items) # Should be exactly 2 or total if less
|
||||
|
||||
# Test 2: Edge case - limit larger than available items
|
||||
large_limit_response = client.responses.input_items.list(response_id=response_id, limit=10)
|
||||
assert large_limit_response.object == "list"
|
||||
assert len(large_limit_response.data) == total_items # Should return all available items
|
||||
|
||||
# Test 3: Edge case - limit of 1
|
||||
single_item_response = client.responses.input_items.list(response_id=response_id, limit=1)
|
||||
assert single_item_response.object == "list"
|
||||
assert len(single_item_response.data) == 1
|
||||
|
||||
# Test 4: Order parameter - ascending vs descending
|
||||
asc_response = client.responses.input_items.list(response_id=response_id, order="asc")
|
||||
desc_response = client.responses.input_items.list(response_id=response_id, order="desc")
|
||||
|
||||
assert asc_response.object == "list"
|
||||
assert desc_response.object == "list"
|
||||
assert len(asc_response.data) == len(desc_response.data) == total_items
|
||||
|
||||
# Verify order is actually different (if we have multiple items)
|
||||
if total_items > 1:
|
||||
# First item in asc should be last item in desc (reversed order)
|
||||
first_asc_content = str(asc_response.data[0].content)
|
||||
first_desc_content = str(desc_response.data[0].content)
|
||||
last_asc_content = str(asc_response.data[-1].content)
|
||||
last_desc_content = str(desc_response.data[-1].content)
|
||||
|
||||
# The first item in asc should be the last item in desc (and vice versa)
|
||||
assert first_asc_content == last_desc_content, (
|
||||
f"Expected first asc ({first_asc_content}) to equal last desc ({last_desc_content})"
|
||||
)
|
||||
assert last_asc_content == first_desc_content, (
|
||||
f"Expected last asc ({last_asc_content}) to equal first desc ({first_desc_content})"
|
||||
)
|
||||
|
||||
# Verify the distinctive content markers are in the right positions
|
||||
assert "Message A" in first_asc_content, "First item in ascending order should contain 'Message A'"
|
||||
assert "Message C" in first_desc_content, "First item in descending order should contain 'Message C'"
|
||||
|
||||
# Test 5: Combined limit and order
|
||||
combined_response = client.responses.input_items.list(response_id=response_id, limit=3, order="desc")
|
||||
assert combined_response.object == "list"
|
||||
assert len(combined_response.data) == min(3, total_items)
|
||||
|
||||
# Test 6: Verify combined response has correct order for first few items
|
||||
if total_items >= 3:
|
||||
# Should get the last 3 items in descending order (most recent first)
|
||||
assert "Message C" in str(combined_response.data[0].content), "First item should be most recent (Message C)"
|
||||
# The exact second and third items depend on the implementation, but let's verify structure
|
||||
for item in combined_response.data:
|
||||
assert hasattr(item, "content")
|
||||
assert hasattr(item, "role")
|
||||
assert hasattr(item, "type")
|
||||
assert item.type == "message"
|
||||
assert item.role in ["user", "assistant"]
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue