From 168b42cd990add51575a5f83ca1c9afa33d5f91e Mon Sep 17 00:00:00 2001 From: Eric Huang Date: Wed, 1 Oct 2025 09:28:58 -0700 Subject: [PATCH] fix: log level # What does this PR do? - categories like "core::server" is not recognized so it's level is not set by 'all=debug' - removed spammy telemetry debug logging ## Test Plan test server launched with LLAMA_STACK_LOGGING='all=debug' --- llama_stack/log.py | 11 ++++++++++- llama_stack/providers/utils/telemetry/tracing.py | 3 --- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/llama_stack/log.py b/llama_stack/log.py index cc4c9d4cf..2a11516fa 100644 --- a/llama_stack/log.py +++ b/llama_stack/log.py @@ -247,7 +247,16 @@ def get_logger( _category_levels.update(parse_yaml_config(config)) logger = logging.getLogger(name) - logger.setLevel(_category_levels.get(category, DEFAULT_LOG_LEVEL)) + if category in _category_levels: + log_level = _category_levels[category] + else: + root_category = category.split("::")[0] + if root_category in _category_levels: + log_level = _category_levels[root_category] + else: + log_level = _category_levels.get("root", DEFAULT_LOG_LEVEL) + logging.warning(f"Unknown logging category: {category}. Falling back to default 'root' level: {log_level}") + logger.setLevel(log_level) return logging.LoggerAdapter(logger, {"category": category}) diff --git a/llama_stack/providers/utils/telemetry/tracing.py b/llama_stack/providers/utils/telemetry/tracing.py index 62cceb13e..58bf8603a 100644 --- a/llama_stack/providers/utils/telemetry/tracing.py +++ b/llama_stack/providers/utils/telemetry/tracing.py @@ -317,7 +317,6 @@ class SpanContextManager: global CURRENT_TRACE_CONTEXT context = CURRENT_TRACE_CONTEXT.get() if not context: - logger.debug("No trace context to pop span") return context.pop_span() @@ -332,7 +331,6 @@ class SpanContextManager: global CURRENT_TRACE_CONTEXT context = CURRENT_TRACE_CONTEXT.get() if not context: - logger.debug("No trace context to push span") return self self.span = context.push_span(self.name, self.attributes) @@ -342,7 +340,6 @@ class SpanContextManager: global CURRENT_TRACE_CONTEXT context = CURRENT_TRACE_CONTEXT.get() if not context: - logger.debug("No trace context to pop span") return context.pop_span()