phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-08-13 21:29:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat(responses): type file results properly (#3117)
Some checks failed
Integration Tests (Replay) / discover-tests (push) Successful in 3s
Details
Integration Auth Tests / test-matrix (oauth2_token) (push) Failing after 9s
Details
Python Package Build Test / build (3.13) (push) Failing after 3s
Details
Test External Providers Installed via Module / test-external-providers-from-module (venv) (push) Has been skipped
Details
Vector IO Integration Tests / test-matrix (3.12, remote::qdrant) (push) Failing after 10s
Details
Test Llama Stack Build / build-custom-container-distribution (push) Failing after 10s
Details
Vector IO Integration Tests / test-matrix (3.13, inline::faiss) (push) Failing after 13s
Details
Vector IO Integration Tests / test-matrix (3.12, remote::chromadb) (push) Failing after 13s
Details
Test Llama Stack Build / generate-matrix (push) Successful in 8s
Details
SqlStore Integration Tests / test-postgres (3.12) (push) Failing after 19s
Details
Python Package Build Test / build (3.12) (push) Failing after 6s
Details
Vector IO Integration Tests / test-matrix (3.13, remote::chromadb) (push) Failing after 12s
Details
Test Llama Stack Build / build-ubi9-container-distribution (push) Failing after 12s
Details
Vector IO Integration Tests / test-matrix (3.13, inline::milvus) (push) Failing after 16s
Details
Test Llama Stack Build / build-single-provider (push) Failing after 10s
Details
Unit Tests / unit-tests (3.12) (push) Failing after 12s
Details
Test External API and Providers / test-external (venv) (push) Failing after 15s
Details
Unit Tests / unit-tests (3.13) (push) Failing after 12s
Details
Update ReadTheDocs / update-readthedocs (push) Failing after 10s
Details
SqlStore Integration Tests / test-postgres (3.13) (push) Failing after 30s
Details
Vector IO Integration Tests / test-matrix (3.12, inline::faiss) (push) Failing after 16s
Details
Vector IO Integration Tests / test-matrix (3.12, inline::milvus) (push) Failing after 14s
Details
Vector IO Integration Tests / test-matrix (3.12, remote::pgvector) (push) Failing after 28s
Details
Integration Tests (Replay) / Integration Tests (, , , client=, vision=) (push) Failing after 11s
Details
Vector IO Integration Tests / test-matrix (3.13, remote::qdrant) (push) Failing after 15s
Details
Vector IO Integration Tests / test-matrix (3.13, remote::weaviate) (push) Failing after 16s
Details
Vector IO Integration Tests / test-matrix (3.12, inline::sqlite-vec) (push) Failing after 16s
Details
Vector IO Integration Tests / test-matrix (3.13, inline::sqlite-vec) (push) Failing after 26s
Details
Test Llama Stack Build / build (push) Failing after 8s
Details
Vector IO Integration Tests / test-matrix (3.12, remote::weaviate) (push) Failing after 19s
Details
Vector IO Integration Tests / test-matrix (3.13, remote::pgvector) (push) Failing after 17s
Details
Pre-commit / pre-commit (push) Successful in 1m16s
Details

Browse source 
Another thing our tests implicitly depended on.
This commit is contained in:
Ashwin Bharambe 2025-08-12 10:39:09 -07:00 • committed by GitHub
parent 4fec49dfdb
commit 1721aafc1f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 117 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

74
docs/_static/llama-stack-spec.html vendored
View file

@ -8293,28 +8293,60 @@
"type": "array",
"items": {
"type": "object",
"additionalProperties": {
"oneOf": [
{
"type": "null"
"properties": {
"attributes": {
"type": "object",
"additionalProperties": {
"oneOf": [
{
"type": "null"
},
{
"type": "boolean"
},
{
"type": "number"
},
{
"type": "string"
},
{
"type": "array"
},
{
"type": "object"
}
]
},
{
"type": "boolean"
},
{
"type": "number"
},
{
"type": "string"
},
{
"type": "array"
},
{
"type": "object"
}
]
}
"description": "(Optional) Key-value attributes associated with the file"
},
"file_id": {
"type": "string",
"description": "Unique identifier of the file containing the result"
},
"filename": {
"type": "string",
"description": "Name of the file containing the result"
},
"score": {
"type": "number",
"description": "Relevance score for this search result (between 0 and 1)"
},
"text": {
"type": "string",
"description": "Text content of the search result"
}
},
"additionalProperties": false,
"required": [
"attributes",
"file_id",
"filename",
"score",
"text"
],
"title": "OpenAIResponseOutputMessageFileSearchToolCallResults",
"description": "Search results returned by the file search operation."
},
"description": "(Optional) Search results returned by the file search operation"
}

46
docs/_static/llama-stack-spec.yaml vendored
View file

@ -6021,14 +6021,44 @@ components:
type: array
items:
type: object
additionalProperties:
oneOf:
- type: 'null'
- type: boolean
- type: number
- type: string
- type: array
- type: object
properties:
attributes:
type: object
additionalProperties:
oneOf:
- type: 'null'
- type: boolean
- type: number
- type: string
- type: array
- type: object
description: >-
(Optional) Key-value attributes associated with the file
file_id:
type: string
description: >-
Unique identifier of the file containing the result
filename:
type: string
description: Name of the file containing the result
score:
type: number
description: >-
Relevance score for this search result (between 0 and 1)
text:
type: string
description: Text content of the search result
additionalProperties: false
required:
- attributes
- file_id
- filename
- score
- text
title: >-
OpenAIResponseOutputMessageFileSearchToolCallResults
description: >-
Search results returned by the file search operation.
description: >-
(Optional) Search results returned by the file search operation
additionalProperties: false

19
llama_stack/apis/agents/openai_responses.py
View file

@ -170,6 +170,23 @@ class OpenAIResponseOutputMessageWebSearchToolCall(BaseModel):
type: Literal["web_search_call"] = "web_search_call"
class OpenAIResponseOutputMessageFileSearchToolCallResults(BaseModel):
"""Search results returned by the file search operation.
:param attributes: (Optional) Key-value attributes associated with the file
:param file_id: Unique identifier of the file containing the result
:param filename: Name of the file containing the result
:param score: Relevance score for this search result (between 0 and 1)
:param text: Text content of the search result
"""
attributes: dict[str, Any]
file_id: str
filename: str
score: float
text: str
@json_schema_type
class OpenAIResponseOutputMessageFileSearchToolCall(BaseModel):
"""File search tool call output message for OpenAI responses.
@ -185,7 +202,7 @@ class OpenAIResponseOutputMessageFileSearchToolCall(BaseModel):
queries: list[str]
status: str
type: Literal["file_search_call"] = "file_search_call"
results: list[dict[str, Any]] | None = None
results: list[OpenAIResponseOutputMessageFileSearchToolCallResults] | None = None
@json_schema_type

14
llama_stack/providers/inline/agents/meta_reference/openai_responses.py
View file

@ -38,6 +38,7 @@ from llama_stack.apis.agents.openai_responses import (
OpenAIResponseOutputMessageContent,
OpenAIResponseOutputMessageContentOutputText,
OpenAIResponseOutputMessageFileSearchToolCall,
OpenAIResponseOutputMessageFileSearchToolCallResults,
OpenAIResponseOutputMessageFunctionToolCall,
OpenAIResponseOutputMessageMCPListTools,
OpenAIResponseOutputMessageWebSearchToolCall,
@ -827,12 +828,13 @@ class OpenAIResponsesImpl:
text = result.metadata["chunks"][i] if "chunks" in result.metadata else None
score = result.metadata["scores"][i] if "scores" in result.metadata else None
message.results.append(
{
"file_id": doc_id,
"filename": doc_id,
"text": text,
"score": score,
}
OpenAIResponseOutputMessageFileSearchToolCallResults(
file_id=doc_id,
filename=doc_id,
text=text,
score=score,
attributes={},
)
)
if error_exc or (result.error_code and result.error_code > 0) or result.error_message:
message.status = "failed"