From 2514822e6a217b5368204abb5c3b579ac6eee25f Mon Sep 17 00:00:00 2001 From: Eric Huang Date: Wed, 5 Nov 2025 11:17:21 -0800 Subject: [PATCH] fix: last_id when listing files in vector store # What does this PR do? ## Test Plan --- .../providers/utils/memory/openai_vector_store_mixin.py | 4 ++-- tests/integration/vector_io/test_openai_vector_stores.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/llama_stack/providers/utils/memory/openai_vector_store_mixin.py b/src/llama_stack/providers/utils/memory/openai_vector_store_mixin.py index 41d4cb2d7..dc305e74e 100644 --- a/src/llama_stack/providers/utils/memory/openai_vector_store_mixin.py +++ b/src/llama_stack/providers/utils/memory/openai_vector_store_mixin.py @@ -886,8 +886,8 @@ class OpenAIVectorStoreMixin(ABC): # Determine pagination info has_more = len(file_objects) > limit - first_id = file_objects[0].id if file_objects else None - last_id = file_objects[-1].id if file_objects else None + first_id = limited_files[0].id if file_objects else None + last_id = limited_files[-1].id if file_objects else None return VectorStoreListFilesResponse( data=limited_files, diff --git a/tests/integration/vector_io/test_openai_vector_stores.py b/tests/integration/vector_io/test_openai_vector_stores.py index 9da5dd25b..8ca29ee0c 100644 --- a/tests/integration/vector_io/test_openai_vector_stores.py +++ b/tests/integration/vector_io/test_openai_vector_stores.py @@ -825,7 +825,7 @@ def test_openai_vector_store_list_files( assert first_page.has_more assert len(first_page.data) == 2 assert first_page.first_id == first_page.data[0].id - assert first_page.last_id != first_page.data[-1].id + assert first_page.last_id == first_page.data[-1].id next_page = compat_client.vector_stores.files.list( vector_store_id=vector_store.id, limit=2, after=first_page.data[-1].id