From 2ad1633d0b133ba78eeae08bdae98309f1929ff5 Mon Sep 17 00:00:00 2001 From: Matthew Farrellee Date: Tue, 23 Sep 2025 12:16:09 -0400 Subject: [PATCH] fix: return llama stack model id from embeddings the openai_embeddings method on OpenAIMixin was returning the provider's model id instead of the llama stack name before - $ ./scripts/integration-tests.sh --stack-config server:ci-tests --setup gpt --subdirs inference --inference-mode live --pattern test_openai_embeddings_single_string ... FAILED tests/integration/inference/test_openai_embeddings.py::test_openai_embeddings_single_string[openai_client-emb=openai/text-embedding-3-small] - AssertionError: assert 'text-embedding-3-small' == 'openai/text-...dding-3-small' FAILED tests/integration/inference/test_openai_embeddings.py::test_openai_embeddings_single_string[llama_stack_client-emb=openai/text-embedding-3-small] - AssertionError: assert 'text-embedding-3-small' == 'openai/text-...dding-3-small' ========================================== 2 failed, 95 deselected, 4 warnings in 3.87s =========================================== after - $ ./scripts/integration-tests.sh --stack-config server:ci-tests --setup gpt --subdirs inference --inference-mode live --pattern test_openai_embeddings_single_string ... ========================================== 2 passed, 95 deselected, 4 warnings in 2.12s =========================================== --- llama_stack/providers/utils/inference/openai_mixin.py | 2 +- tests/integration/suites.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/llama_stack/providers/utils/inference/openai_mixin.py b/llama_stack/providers/utils/inference/openai_mixin.py index c57f65bca..2fe343f63 100644 --- a/llama_stack/providers/utils/inference/openai_mixin.py +++ b/llama_stack/providers/utils/inference/openai_mixin.py @@ -296,7 +296,7 @@ class OpenAIMixin(ABC): return OpenAIEmbeddingsResponse( data=data, - model=response.model, + model=model, usage=usage, ) diff --git a/tests/integration/suites.py b/tests/integration/suites.py index fb2c44308..354dc1f4c 100644 --- a/tests/integration/suites.py +++ b/tests/integration/suites.py @@ -87,7 +87,7 @@ SETUP_DEFINITIONS: dict[str, Setup] = { description="OpenAI GPT models for high-quality responses and tool calling", defaults={ "text_model": "openai/gpt-4o", - "embedding_model": "sentence-transformers/all-MiniLM-L6-v2", + "embedding_model": "openai/text-embedding-3-small", }, ), "tgi": Setup(