From 2e4eedce14132e5ed125766404fa05f973ab84a5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Han?= Date: Fri, 11 Jul 2025 16:25:33 +0200 Subject: [PATCH] fix: container build on podman (#2723) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit # What does this PR do? COPY with chmod does not work, see https://github.com/containers/buildah/issues/4614. Also Docker arguably implements it. Anyway, this command is not even needed since later don't we do: ``` RUN mkdir -p /.llama /.cache && chmod -R g+rw /app /.llama /.cache ``` And providers.d will get the right modes. ## Test Plan Build with CONTAINER_BINARY=podman and success Signed-off-by: Sébastien Han --- llama_stack/distribution/build_container.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/llama_stack/distribution/build_container.sh b/llama_stack/distribution/build_container.sh index d9a918fb5..6e794b36f 100755 --- a/llama_stack/distribution/build_container.sh +++ b/llama_stack/distribution/build_container.sh @@ -96,7 +96,7 @@ FROM $container_base WORKDIR /app # We install the Python 3.12 dev headers and build tools so that any -# C‑extension wheels (e.g. polyleven, faiss‑cpu) can compile successfully. +# C-extension wheels (e.g. polyleven, faiss-cpu) can compile successfully. RUN dnf -y update && dnf install -y iputils git net-tools wget \ vim-minimal python3.12 python3.12-pip python3.12-wheel \ @@ -169,7 +169,7 @@ if [ -n "$run_config" ]; then echo "Copying external providers directory: $external_providers_dir" cp -r "$external_providers_dir" "$BUILD_CONTEXT_DIR/providers.d" add_to_container << EOF -COPY --chmod=g+w providers.d /.llama/providers.d +COPY providers.d /.llama/providers.d EOF fi