phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-12-06 02:30:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor: enforce top-level imports for llama-stack-api

Browse source 
Enforce that all imports from llama-stack-api use the form:

from llama_stack_api import <symbol>

 This prevents external code from accessing internal package structure
 (e.g., llama_stack_api.agents, llama_stack_api.common.*) and establishes
 a clear public API boundary.

 Changes:
 - Export 400+ symbols from llama_stack_api/__init__.py
 - Include all API types, common utilities, and strong_typing helpers
 - Update files across src/llama_stack, docs/, tests/, scripts/
 - Convert all submodule imports to top-level imports
 - ensure docs use the proper importing structure

 Addresses PR review feedback requiring explicit __all__ definition to
 prevent "peeking inside" the API package.

Signed-off-by: Charlie Doern <cdoern@redhat.com>
This commit is contained in:
Charlie Doern 2025-11-13 14:03:30 -05:00
parent b7480e9c88
commit 2e5d1c8881
270 changed files with 1587 additions and 750 deletions
Download patch file Download diff file Expand all files Collapse all files

3
tests/unit/core/routers/test_safety_router.py
View file

@ -6,8 +6,7 @@
from unittest.mock import AsyncMock
from llama_stack_api.safety import ModerationObject, ModerationObjectResults
from llama_stack_api.shields import ListShieldsResponse, Shield
from llama_stack_api import ListShieldsResponse, ModerationObject, ModerationObjectResults, Shield
from llama_stack.core.datatypes import SafetyConfig
from llama_stack.core.routers.safety import SafetyRouter

2
tests/unit/core/routers/test_vector_io.py
View file

@ -7,7 +7,7 @@
from unittest.mock import AsyncMock, Mock
import pytest
from llama_stack_api.vector_io import OpenAICreateVectorStoreRequestWithExtraBody
from llama_stack_api import OpenAICreateVectorStoreRequestWithExtraBody
from llama_stack.core.routers.vector_io import VectorIORouter

4
tests/unit/core/test_stack_validation.py
View file

@ -9,9 +9,7 @@
from unittest.mock import AsyncMock
import pytest
from llama_stack_api.datatypes import Api
from llama_stack_api.models import ListModelsResponse, Model, ModelType
from llama_stack_api.shields import ListShieldsResponse, Shield
from llama_stack_api import Api, ListModelsResponse, ListShieldsResponse, Model, ModelType, Shield
from llama_stack.core.datatypes import QualifiedModel, SafetyConfig, StackRunConfig, StorageConfig, VectorStoresConfig
from llama_stack.core.stack import validate_safety_config, validate_vector_stores_config