From 2e93ba1f11c3a851183c726190c3b166f01135a8 Mon Sep 17 00:00:00 2001 From: Francisco Javier Arceo Date: Fri, 10 Oct 2025 14:47:22 -0400 Subject: [PATCH] commenting out compat client test because we shouldn't use that yet Signed-off-by: Francisco Javier Arceo --- .../responses/test_conversation_responses.py | 54 ++++++++++--------- 1 file changed, 28 insertions(+), 26 deletions(-) diff --git a/tests/integration/responses/test_conversation_responses.py b/tests/integration/responses/test_conversation_responses.py index ff762e0ea..6086ffd9e 100644 --- a/tests/integration/responses/test_conversation_responses.py +++ b/tests/integration/responses/test_conversation_responses.py @@ -107,17 +107,18 @@ class TestConversationResponses: ) assert any(word in str(exc_info.value).lower() for word in ["not found", "404"]) - response = openai_client.responses.create( - model=text_model_id, input=[{"role": "user", "content": "First response"}] - ) - with pytest.raises(Exception) as exc_info: - openai_client.responses.create( - model=text_model_id, - input=[{"role": "user", "content": "Hello"}], - conversation="conv_test123", - previous_response_id=response.id, - ) - assert "mutually exclusive" in str(exc_info.value).lower() + # + # response = openai_client.responses.create( + # model=text_model_id, input=[{"role": "user", "content": "First response"}] + # ) + # with pytest.raises(Exception) as exc_info: + # openai_client.responses.create( + # model=text_model_id, + # input=[{"role": "user", "content": "Hello"}], + # conversation="conv_test123", + # previous_response_id=response.id, + # ) + # assert "mutually exclusive" in str(exc_info.value).lower() def test_conversation_backward_compatibility(self, openai_client, text_model_id): """Test that responses work without conversation parameter (backward compatibility).""" @@ -128,18 +129,19 @@ class TestConversationResponses: assert response.id.startswith("resp_") assert len(response.output_text.strip()) > 0 - def test_conversation_compat_client(self, compat_client, text_model_id): - """Test conversation parameter works with compatibility client.""" - if not hasattr(compat_client, "conversations"): - pytest.skip("compat_client does not support conversations API") - - conversation = compat_client.conversations.create() - response = compat_client.responses.create( - model=text_model_id, input="Tell me a joke", conversation=conversation.id - ) - - assert response is not None - assert len(response.output_text.strip()) > 0 - - conversation_items = compat_client.conversations.items.list(conversation.id) - assert len(conversation_items.data) >= 2 + # this is not ready yet + # def test_conversation_compat_client(self, compat_client, text_model_id): + # """Test conversation parameter works with compatibility client.""" + # if not hasattr(compat_client, "conversations"): + # pytest.skip("compat_client does not support conversations API") + # + # conversation = compat_client.conversations.create() + # response = compat_client.responses.create( + # model=text_model_id, input="Tell me a joke", conversation=conversation.id + # ) + # + # assert response is not None + # assert len(response.output_text.strip()) > 0 + # + # conversation_items = compat_client.conversations.items.list(conversation.id) + # assert len(conversation_items.data) >= 2