From 2f017b8590a31eda3949af824dc310a7e0845273 Mon Sep 17 00:00:00 2001 From: Francisco Javier Arceo Date: Thu, 13 Feb 2025 22:00:43 -0500 Subject: [PATCH] Adding an additional comment Signed-off-by: Francisco Javier Arceo --- .../providers/inline/vector_io/sqlite_vec/sqlite_vec.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/llama_stack/providers/inline/vector_io/sqlite_vec/sqlite_vec.py b/llama_stack/providers/inline/vector_io/sqlite_vec/sqlite_vec.py index fe53c8279..7c461c350 100644 --- a/llama_stack/providers/inline/vector_io/sqlite_vec/sqlite_vec.py +++ b/llama_stack/providers/inline/vector_io/sqlite_vec/sqlite_vec.py @@ -79,9 +79,10 @@ class SQLiteVecIndex(EmbeddingIndex): try: # Start transaction cur.execute("BEGIN TRANSACTION") + # Serialize and insert the chunk metadata. chunk_data = [(chunk.model_dump_json(),) for chunk in chunks] cur.executemany(f"INSERT INTO {self.metadata_table} (chunk) VALUES (?)", chunk_data) - # Fetch the last N inserted row IDs + # Fetch the last *n* inserted row_ids -- note: this is more reliable than `row_id = cur.lastrowid` cur.execute(f"SELECT rowid FROM {self.metadata_table} ORDER BY rowid DESC LIMIT {len(chunks)}") row_ids = [row[0] for row in cur.fetchall()] row_ids.reverse() # Reverse to maintain the correct order of insertion