remove type ignore

This commit is contained in:
Xi Yan 2024-11-07 11:15:36 -08:00
parent 283b5c1def
commit 3acd37bcb3

View file

@ -38,13 +38,13 @@ EvalCandidate = Annotated[
@json_schema_type @json_schema_type
class BenchmarkEvalTaskConfig(BaseModel): class BenchmarkEvalTaskConfig(BaseModel):
eval_candidate: EvalCandidate # type: ignore eval_candidate: EvalCandidate
@json_schema_type @json_schema_type
class AppEvalTaskConfig(BaseModel): class AppEvalTaskConfig(BaseModel):
eval_candidate: EvalCandidate # type: ignore eval_candidate: EvalCandidate
scoring_params: Dict[str, ScoringFnParams] = Field( # type: ignore scoring_params: Dict[str, ScoringFnParams] = Field(
description="Map between scoring function id and parameters", description="Map between scoring function id and parameters",
default_factory=dict, default_factory=dict,
) )
@ -83,7 +83,7 @@ class Eval(Protocol):
self, self,
input_rows: List[Dict[str, Any]], input_rows: List[Dict[str, Any]],
scoring_functions: List[str], scoring_functions: List[str],
eval_task_config: EvalTaskConfig, # type: ignore eval_task_config: EvalTaskConfig,
) -> EvaluateResponse: ... ) -> EvaluateResponse: ...
@webmethod(route="/eval/job/status", method="GET") @webmethod(route="/eval/job/status", method="GET")