phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-08-12 04:50:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: remove redundant code from unregister_dataset (#2971)
Some checks failed
Integration Tests / discover-tests (push) Has been skipped
Details
Integration Tests / record-tests (push) Has been skipped
Details
Integration Tests / run-tests (push) Has been skipped
Details
Python Package Build Test / build (3.12) (push) Failing after 8s
Details
Vector IO Integration Tests / test-matrix (3.13, inline::faiss) (push) Failing after 12s
Details
Test Llama Stack Build / generate-matrix (push) Successful in 10s
Details
SqlStore Integration Tests / test-postgres (3.12) (push) Failing after 17s
Details
Vector IO Integration Tests / test-matrix (3.12, remote::chromadb) (push) Failing after 14s
Details
Test Llama Stack Build / build-single-provider (push) Failing after 11s
Details
Vector IO Integration Tests / test-matrix (3.12, inline::faiss) (push) Failing after 15s
Details
Vector IO Integration Tests / test-matrix (3.13, remote::pgvector) (push) Failing after 12s
Details
Unit Tests / unit-tests (3.13) (push) Failing after 9s
Details
Test External Providers Installed via Module / test-external-providers-from-module (venv) (push) Failing after 10s
Details
Test Llama Stack Build / build-custom-container-distribution (push) Failing after 13s
Details
Test External API and Providers / test-external (venv) (push) Failing after 12s
Details
Integration Auth Tests / test-matrix (oauth2_token) (push) Failing after 20s
Details
Vector IO Integration Tests / test-matrix (3.13, inline::milvus) (push) Failing after 13s
Details
Vector IO Integration Tests / test-matrix (3.13, inline::sqlite-vec) (push) Failing after 19s
Details
Unit Tests / unit-tests (3.12) (push) Failing after 16s
Details
Vector IO Integration Tests / test-matrix (3.12, inline::milvus) (push) Failing after 17s
Details
Test Llama Stack Build / build (push) Failing after 7s
Details
Test Llama Stack Build / build-ubi9-container-distribution (push) Failing after 19s
Details
Vector IO Integration Tests / test-matrix (3.12, inline::sqlite-vec) (push) Failing after 26s
Details
Vector IO Integration Tests / test-matrix (3.13, remote::chromadb) (push) Failing after 24s
Details
Python Package Build Test / build (3.13) (push) Failing after 53s
Details
Update ReadTheDocs / update-readthedocs (push) Failing after 52s
Details
SqlStore Integration Tests / test-postgres (3.13) (push) Failing after 1m0s
Details
Vector IO Integration Tests / test-matrix (3.12, remote::pgvector) (push) Failing after 58s
Details
Pre-commit / pre-commit (push) Successful in 1m44s
Details

Browse source 
get_dataset() will raise an exception if a dataset won't be returned

client handling is redundant

Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
This commit is contained in:
Nathan Weinberg 2025-07-30 19:40:01 -04:00 • committed by GitHub
parent cb7354a9ce
commit 406ca72957
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
llama_stack/distribution/routing_tables/datasets.py
View file

@ -88,6 +88,4 @@ class DatasetsRoutingTable(CommonRoutingTableImpl, Datasets):
async def unregister_dataset(self, dataset_id: str) -> None: async def unregister_dataset(self, dataset_id: str) -> None:
dataset = await self.get_dataset(dataset_id) dataset = await self.get_dataset(dataset_id)
if dataset is None:
raise DatasetNotFoundError(dataset_id)
await self.unregister_object(dataset) await self.unregister_object(dataset)