phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-10-16 14:57:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

change register signature to make params required

Browse source
This commit is contained in:
Dinesh Yeduguru 2024-11-11 11:49:07 -08:00
parent 4206f07ada
commit 4369c2d0b6
5 changed files with 43 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

33
llama_stack/apis/memory_banks/memory_banks.py
View file

@ -65,15 +65,39 @@ class GraphMemoryBank(MemoryBank):
@json_schema_type
class VectorMemoryBankParams(BaseModel):
type: Literal[MemoryBankType.vector.value] = MemoryBankType.vector.value
memory_bank_type: Literal[MemoryBankType.vector.value] = MemoryBankType.vector.value
embedding_model: str
chunk_size_in_tokens: int
overlap_size_in_tokens: Optional[int] = None
@json_schema_type
class KeyValueMemoryBankParams(BaseModel):
memory_bank_type: Literal[MemoryBankType.keyvalue.value] = (
MemoryBankType.keyvalue.value
)
@json_schema_type
class KeywordMemoryBankParams(BaseModel):
memory_bank_type: Literal[MemoryBankType.keyword.value] = (
MemoryBankType.keyword.value
)
@json_schema_type
class GraphMemoryBankParams(BaseModel):
memory_bank_type: Literal[MemoryBankType.graph.value] = MemoryBankType.graph.value
BankParams = Annotated[
Union[VectorMemoryBankParams],
Field(discriminator="type"),
Union[
VectorMemoryBankParams,
KeyValueMemoryBankParams,
KeywordMemoryBankParams,
GraphMemoryBankParams,
],
Field(discriminator="memory_bank_type"),
]
@ -89,8 +113,7 @@ class MemoryBanks(Protocol):
async def register_memory_bank(
self,
memory_bank_id: str,
memory_bank_type: MemoryBankType,
params: BankParams,
provider_id: Optional[str] = None,
provider_memorybank_id: Optional[str] = None,
params: Optional[BankParams] = None,
) -> MemoryBank: ...