From 4754f6dd9567e9174902d383487362c4df5c54fd Mon Sep 17 00:00:00 2001 From: Ashwin Bharambe Date: Tue, 22 Jul 2025 14:29:16 -0700 Subject: [PATCH] add warning --- .github/workflows/integration-tests.yml | 2 +- .github/workflows/integration-vector-io-tests.yml | 2 +- llama_stack/distribution/routing_tables/common.py | 5 +++++ 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml index f8f01756d..082f1e204 100644 --- a/.github/workflows/integration-tests.yml +++ b/.github/workflows/integration-tests.yml @@ -99,7 +99,7 @@ jobs: uv run pytest -s -v tests/integration/${{ matrix.test-type }} --stack-config=${stack_config} \ -k "not(builtin_tool or safety_with_image or code_interpreter or test_rag)" \ --text-model="ollama/llama3.2:3b-instruct-fp16" \ - --embedding-model=all-MiniLM-L6-v2 \ + --embedding-model=sentence-transformers/all-MiniLM-L6-v2 \ --safety-shield=$SAFETY_MODEL \ --color=yes \ --capture=tee-sys | tee pytest-${{ matrix.test-type }}.log diff --git a/.github/workflows/integration-vector-io-tests.yml b/.github/workflows/integration-vector-io-tests.yml index ec236b33b..525c17d46 100644 --- a/.github/workflows/integration-vector-io-tests.yml +++ b/.github/workflows/integration-vector-io-tests.yml @@ -114,7 +114,7 @@ jobs: run: | uv run pytest -sv --stack-config="inference=inline::sentence-transformers,vector_io=${{ matrix.vector-io-provider }}" \ tests/integration/vector_io \ - --embedding-model all-MiniLM-L6-v2 + --embedding-model sentence-transformers/all-MiniLM-L6-v2 - name: Check Storage and Memory Available After Tests if: ${{ always() }} diff --git a/llama_stack/distribution/routing_tables/common.py b/llama_stack/distribution/routing_tables/common.py index fd810f8cc..2f6ac90bb 100644 --- a/llama_stack/distribution/routing_tables/common.py +++ b/llama_stack/distribution/routing_tables/common.py @@ -245,6 +245,11 @@ async def lookup_model(routing_table: CommonRoutingTableImpl, model_id: str) -> if model is not None: return model + logger.warning( + f"WARNING: model identifier '{model_id}' not found in routing table. Falling back to " + "searching in all providers. This is only for backwards compatibility and will stop working " + "soon. Migrate your calls to use fully scoped `provider_id/model_id` names." + ) # if not found, this means model_id is an unscoped provider_model_id, we need # to iterate (given a lack of an efficient index on the KVStore) models = await routing_table.get_all_with_type("model")