From 4a1fa139f160ab28560106df11fed37fa8a85ad0 Mon Sep 17 00:00:00 2001
From: Omar Abdelwahab <omara@fb.com>
Date: Wed, 12 Nov 2025 16:11:16 -0800
Subject: [PATCH] revert(ci): Remove unnecessary CI workarounds from action.yml

Now that we've fixed the actual root cause (api_recorder.py missing the
authorization parameter), we can revert all the CI workarounds that were
added during troubleshooting:

Removed changes:
- Cache clearing (venv, pycache, UV cache)
- PYTHONDONTWRITEBYTECODE environment variable
- --no-install-project flag
- Force reinstalling llama-stack
- Installing ci-tests distribution dependencies via llama CLI
- Final bytecode cache cleanup

These were all based on incorrect diagnosis (missing dependencies or module
caching) and are no longer needed. The real fix was updating api_recorder.py
to include the authorization parameter in patched tool runtime methods.

Restoring the simpler, original CI setup that just runs 'uv sync --all-groups'.
---
 .github/actions/setup-runner/action.yml | 34 ++-----------------------
 1 file changed, 2 insertions(+), 32 deletions(-)

diff --git a/.github/actions/setup-runner/action.yml b/.github/actions/setup-runner/action.yml
index 737a59a01..3237abb67 100644
--- a/.github/actions/setup-runner/action.yml
+++ b/.github/actions/setup-runner/action.yml
@@ -28,7 +28,6 @@ runs:
       shell: bash
       env:
         UV_EXTRA_INDEX_URL: ${{ steps.client-config.outputs.uv-extra-index-url }}
-        PYTHONDONTWRITEBYTECODE: 1
       run: |
         # Export UV env vars for current step and persist to GITHUB_ENV for subsequent steps
         if [ -n "$UV_EXTRA_INDEX_URL" ]; then
@@ -38,33 +37,8 @@ runs:
           echo "Exported UV environment variables for current and subsequent steps"
         fi
 
-        echo "Clearing cached virtual environment to ensure fresh install"
-        # Remove cached venv that may contain old code
-        if [ -d ".venv" ]; then
-          echo "Removing cached .venv directory"
-          rm -rf .venv
-        fi
-
-        # Clear Python bytecode cache
-        find . -type d -name "__pycache__" -exec rm -rf {} + 2>/dev/null || true
-        find . -name "*.pyc" -delete 2>/dev/null || true
-
-        # Clear uv's cache directory to force rebuilding wheels from source
-        if [ -n "$UV_CACHE_DIR" ] && [ -d "$UV_CACHE_DIR" ]; then
-          echo "Clearing UV cache at $UV_CACHE_DIR"
-          rm -rf "$UV_CACHE_DIR"/*
-        fi
-
-        echo "Syncing dependencies with uv (will create fresh venv)"
-        # Use --no-install-project to avoid installing llama-stack yet (we'll do it later with -e)
-        # This prevents Python from importing old code during sync
-        uv sync --all-groups --no-install-project
-
-        echo "Force reinstalling llama-stack from source to ensure latest changes"
-        uv pip install --force-reinstall --no-deps -e .
-
-        echo "Installing ci-tests distribution dependencies"
-        uv run llama stack list-deps ci-tests | xargs -L1 uv pip install
+        echo "Updating project dependencies via uv sync"
+        uv sync --all-groups
 
         echo "Installing ad-hoc dependencies"
         uv pip install faiss-cpu
@@ -75,9 +49,5 @@ runs:
           uv pip install ${{ steps.client-config.outputs.install-source }}
         fi
 
-        echo "Final cleanup: removing all bytecode cache after installations"
-        find . -name "*.pyc" -type f -delete 2>/dev/null || true
-        find . -type d -name "__pycache__" -exec rm -rf {} + 2>/dev/null || true
-
         echo "Installed llama packages"
         uv pip list | grep llama