From 52a9f53590b585864b32b62078b6ceda5a09b72f Mon Sep 17 00:00:00 2001 From: Francisco Javier Arceo Date: Mon, 7 Jul 2025 22:29:37 -0400 Subject: [PATCH] added tests for all methods Signed-off-by: Francisco Javier Arceo --- llama_stack/providers/remote/vector_io/milvus/milvus.py | 1 - .../vector_io/test_vector_io_openai_vector_stores.py | 5 +++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/llama_stack/providers/remote/vector_io/milvus/milvus.py b/llama_stack/providers/remote/vector_io/milvus/milvus.py index d97582a13..1f65e580e 100644 --- a/llama_stack/providers/remote/vector_io/milvus/milvus.py +++ b/llama_stack/providers/remote/vector_io/milvus/milvus.py @@ -430,7 +430,6 @@ class MilvusVectorIOAdapter(OpenAIVectorStoreMixin, VectorIO, VectorDBsProtocolP logger.error(f"Error loading openai vector store file contents for {file_id} in store {store_id}: {e}") return [] - async def _delete_openai_vector_store_file_from_storage(self, store_id: str, file_id: str) -> None: """Delete vector store file metadata from Milvus database.""" try: diff --git a/tests/unit/providers/vector_io/test_vector_io_openai_vector_stores.py b/tests/unit/providers/vector_io/test_vector_io_openai_vector_stores.py index 05a36149c..0a109e833 100644 --- a/tests/unit/providers/vector_io/test_vector_io_openai_vector_stores.py +++ b/tests/unit/providers/vector_io/test_vector_io_openai_vector_stores.py @@ -336,6 +336,7 @@ async def test_save_openai_vector_store_file(milvus_vec_adapter, tmp_path_factor # validating we don't raise an exception await milvus_vec_adapter._save_openai_vector_store_file(store_id, file_id, file_info, file_contents) + @pytest.mark.asyncio async def test_update_openai_vector_store_file(milvus_vec_adapter, tmp_path_factory): store_id = "vs_1234" @@ -359,7 +360,6 @@ async def test_update_openai_vector_store_file(milvus_vec_adapter, tmp_path_fact updated_file_info = file_info.copy() updated_file_info["filename"] = "updated_test_file.txt" - await milvus_vec_adapter._update_openai_vector_store_file( store_id, file_id, @@ -370,6 +370,7 @@ async def test_update_openai_vector_store_file(milvus_vec_adapter, tmp_path_fact assert loaded_contents == updated_file_info assert loaded_contents != file_info + @pytest.mark.asyncio async def test_load_openai_vector_store_file_contents(milvus_vec_adapter, tmp_path_factory): store_id = "vs_1234" @@ -416,4 +417,4 @@ async def test_delete_openai_vector_store_file_from_storage(milvus_vec_adapter, await milvus_vec_adapter._delete_openai_vector_store_file_from_storage(store_id, file_id) loaded_contents = await milvus_vec_adapter._load_openai_vector_store_file_contents(store_id, file_id) - assert loaded_contents == [] \ No newline at end of file + assert loaded_contents == []