From 537dc693ee3a8240dbc788b613f7c67b85ae4d22 Mon Sep 17 00:00:00 2001
From: Stefan Thaler <120387118+SjjThaler@users.noreply.github.com>
Date: Thu, 24 Jul 2025 17:51:46 +0100
Subject: [PATCH] chore: add mypy coverage to inspect.py and library_client.py
 in /distribution (#2707)

# What does this PR do?
Adds type guards in /distribution/inspect.py and ignores a valid-type
mypy error in library_client.py. This PR is part of issue #2647 . I'm
rather unsure whether ignoring the valid-type error is correct in this
case. It appears that args[0] is interpreted as [any] but I didn't find
any way to specify the type.

<!-- If resolving an issue, uncomment and update the line below -->
<!-- Closes #[issue-number] -->


<!-- Describe the tests you ran to verify your changes with result
summaries. *Provide clear instructions so the plan can be easily
re-executed.* -->
---
 llama_stack/distribution/inspect.py        | 2 ++
 llama_stack/distribution/library_client.py | 3 ++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/llama_stack/distribution/inspect.py b/llama_stack/distribution/inspect.py
index 5822070ad..d6a598982 100644
--- a/llama_stack/distribution/inspect.py
+++ b/llama_stack/distribution/inspect.py
@@ -54,6 +54,7 @@ class DistributionInspectImpl(Inspect):
                             provider_types=[],  # These APIs don't have "real" providers - they're internal to the stack
                         )
                         for e in endpoints
+                        if e.methods is not None
                     ]
                 )
             else:
@@ -67,6 +68,7 @@ class DistributionInspectImpl(Inspect):
                                 provider_types=[p.provider_type for p in providers],
                             )
                             for e in endpoints
+                            if e.methods is not None
                         ]
                     )
 
diff --git a/llama_stack/distribution/library_client.py b/llama_stack/distribution/library_client.py
index 5dc0078d4..6503c13b2 100644
--- a/llama_stack/distribution/library_client.py
+++ b/llama_stack/distribution/library_client.py
@@ -445,8 +445,9 @@ class AsyncLlamaStackAsLibraryClient(AsyncLlamaStackClient):
         # we use asynchronous impl always internally and channel all requests to AsyncLlamaStackClient
         # however, the top-level caller may be a SyncAPIClient -- so its stream_cls might be a Stream (SyncStream)
         # so we need to convert it to AsyncStream
+        # mypy can't track runtime variables inside the [...] of a generic, so ignore that check
         args = get_args(stream_cls)
-        stream_cls = AsyncStream[args[0]]
+        stream_cls = AsyncStream[args[0]]  # type: ignore[valid-type]
         response = AsyncAPIResponse(
             raw=mock_response,
             client=self,