From 558d109ab727a95ad9df456161c1bede2ff110f3 Mon Sep 17 00:00:00 2001
From: Ashwin Bharambe <ashwin.bharambe@gmail.com>
Date: Fri, 23 May 2025 10:59:30 -0700
Subject: [PATCH] fix: signature change to match OpenAI SDK (#2237)

---
 docs/_static/llama-stack-spec.html                          | 4 ++--
 docs/_static/llama-stack-spec.yaml                          | 4 ++--
 llama_stack/apis/agents/agents.py                           | 6 +++---
 .../providers/inline/agents/meta_reference/agents.py        | 4 ++--
 .../inline/agents/meta_reference/openai_responses.py        | 4 ++--
 5 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/docs/_static/llama-stack-spec.html b/docs/_static/llama-stack-spec.html
index cdbba5dd1..b3e982029 100644
--- a/docs/_static/llama-stack-spec.html
+++ b/docs/_static/llama-stack-spec.html
@@ -1395,7 +1395,7 @@
                 ]
             }
         },
-        "/v1/openai/v1/responses/{id}": {
+        "/v1/openai/v1/responses/{response_id}": {
             "get": {
                 "responses": {
                     "200": {
@@ -1427,7 +1427,7 @@
                 "description": "Retrieve an OpenAI response by its ID.",
                 "parameters": [
                     {
-                        "name": "id",
+                        "name": "response_id",
                         "in": "path",
                         "description": "The ID of the OpenAI response to retrieve.",
                         "required": true,
diff --git a/docs/_static/llama-stack-spec.yaml b/docs/_static/llama-stack-spec.yaml
index 1b368762f..18cd2b046 100644
--- a/docs/_static/llama-stack-spec.yaml
+++ b/docs/_static/llama-stack-spec.yaml
@@ -963,7 +963,7 @@ paths:
           required: true
           schema:
             type: string
-  /v1/openai/v1/responses/{id}:
+  /v1/openai/v1/responses/{response_id}:
     get:
       responses:
         '200':
@@ -986,7 +986,7 @@ paths:
         - Agents
       description: Retrieve an OpenAI response by its ID.
       parameters:
-        - name: id
+        - name: response_id
           in: path
           description: >-
             The ID of the OpenAI response to retrieve.
diff --git a/llama_stack/apis/agents/agents.py b/llama_stack/apis/agents/agents.py
index 8ecafdf26..5e857c895 100644
--- a/llama_stack/apis/agents/agents.py
+++ b/llama_stack/apis/agents/agents.py
@@ -579,14 +579,14 @@ class Agents(Protocol):
     #
     # Both of these APIs are inherently stateful.
 
-    @webmethod(route="/openai/v1/responses/{id}", method="GET")
+    @webmethod(route="/openai/v1/responses/{response_id}", method="GET")
     async def get_openai_response(
         self,
-        id: str,
+        response_id: str,
     ) -> OpenAIResponseObject:
         """Retrieve an OpenAI response by its ID.
 
-        :param id: The ID of the OpenAI response to retrieve.
+        :param response_id: The ID of the OpenAI response to retrieve.
         :returns: An OpenAIResponseObject.
         """
         ...
diff --git a/llama_stack/providers/inline/agents/meta_reference/agents.py b/llama_stack/providers/inline/agents/meta_reference/agents.py
index 8f54cc737..e98799ae6 100644
--- a/llama_stack/providers/inline/agents/meta_reference/agents.py
+++ b/llama_stack/providers/inline/agents/meta_reference/agents.py
@@ -305,9 +305,9 @@ class MetaReferenceAgentsImpl(Agents):
     # OpenAI responses
     async def get_openai_response(
         self,
-        id: str,
+        response_id: str,
     ) -> OpenAIResponseObject:
-        return await self.openai_responses_impl.get_openai_response(id)
+        return await self.openai_responses_impl.get_openai_response(response_id)
 
     async def create_openai_response(
         self,
diff --git a/llama_stack/providers/inline/agents/meta_reference/openai_responses.py b/llama_stack/providers/inline/agents/meta_reference/openai_responses.py
index f5b0d8c31..92345a12f 100644
--- a/llama_stack/providers/inline/agents/meta_reference/openai_responses.py
+++ b/llama_stack/providers/inline/agents/meta_reference/openai_responses.py
@@ -214,9 +214,9 @@ class OpenAIResponsesImpl:
 
     async def get_openai_response(
         self,
-        id: str,
+        response_id: str,
     ) -> OpenAIResponseObject:
-        response_with_input = await self._get_previous_response_with_input(id)
+        response_with_input = await self._get_previous_response_with_input(response_id)
         return response_with_input.response
 
     async def create_openai_response(