phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-06-27 18:50:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor: Replace SQLITE_DB_PATH by SQLITE_STORE_DIR env in templates (#2055)

Browse source 
# What does this PR do?

The telemetry provider configs is the only one who leverages the env var
`SQLITE_DB_PATH` for pointing to persistent data in the respective
templates, whereas usually `SQLITE_STORE_DIR` is used.

This PR modifies the `sqlite_db_path` in various telemetry configuration
files to use the environment variable `SQLITE_STORE_DIR` instead of
`SQLITE_DB_PATH`. This change ensures that _only_ the SQLITE_STORE_DIR
needs to be set to point to a different persistence location for
providers.

All references to `SQLITE_DB_PATH` have been removed.

Another improvement could be to move `sqlite_db_path` to `db_path` in
the telemetry provider config, to align with the other provider
configurations. That could be done by another PR (if wanted).
This commit is contained in:
Roland Huß 2025-04-30 00:28:10 +02:00 • committed by GitHub
parent 7532f4cdb2
commit 5a2bfd6ad5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
35 changed files with 36 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

2
llama_stack/providers/inline/telemetry/meta_reference/config.py
View file

@ -54,5 +54,5 @@ class TelemetryConfig(BaseModel):
return {
"service_name": "${env.OTEL_SERVICE_NAME:​}",
"sinks": "${env.TELEMETRY_SINKS:console,sqlite}",
"sqlite_db_path": "${env.SQLITE_DB_PATH:" + __distro_dir__ + "/" + db_name + "}",
"sqlite_db_path": "${env.SQLITE_STORE_DIR:" + __distro_dir__ + "}/" + db_name,
}