phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-10-07 20:50:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

chore: require valid logging category

Browse source 
# What does this PR do?


## Test Plan
This commit is contained in:
Eric Huang 2025-10-06 14:58:45 -07:00
parent 597d405e13
commit 5b3713ec0a
2 changed files with 9 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
llama_stack/core/conversations/conversations.py
View file

@ -32,7 +32,7 @@ from llama_stack.providers.utils.sqlstore.sqlstore import (
sqlstore_impl, sqlstore_impl,
) )
logger = get_logger(name=__name__, category="openai::conversations") logger = get_logger(name=__name__, category="openai_conversations")
class ConversationServiceConfig(BaseModel): class ConversationServiceConfig(BaseModel):

12
llama_stack/log.py
View file

@ -31,12 +31,17 @@ CATEGORIES = [
"client", "client",
"telemetry", "telemetry",
"openai_responses", "openai_responses",
"openai_conversations",
"testing", "testing",
"providers", "providers",
"models", "models",
"files", "files",
"vector_io", "vector_io",
"tool_runtime", "tool_runtime",
"cli",
"post_training",
"scoring",
"tests",
] ]
UNCATEGORIZED = "uncategorized" UNCATEGORIZED = "uncategorized"
@ -261,11 +266,10 @@ def get_logger(
if root_category in _category_levels: if root_category in _category_levels:
log_level = _category_levels[root_category] log_level = _category_levels[root_category]
else: else:
assert category == UNCATEGORIZED, (
f"Unknown logging category: {category}. To resolve, choose a valid category from the CATEGORIES list or add it to the CATEGORIES list."
)
log_level = _category_levels.get("root", DEFAULT_LOG_LEVEL) log_level = _category_levels.get("root", DEFAULT_LOG_LEVEL)
if category != UNCATEGORIZED:
logging.warning(
f"Unknown logging category: {category}. Falling back to default 'root' level: {log_level}"
)
logger.setLevel(log_level) logger.setLevel(log_level)
return logging.LoggerAdapter(logger, {"category": category}) return logging.LoggerAdapter(logger, {"category": category})