fix tests

This commit is contained in:
Dinesh Yeduguru 2024-11-08 17:00:15 -08:00
parent 24b914f0fe
commit 5cdcdbe074
3 changed files with 37 additions and 20 deletions

View file

@ -274,9 +274,10 @@ class MemoryBanksRoutingTable(CommonRoutingTableImpl, MemoryBanks):
async def register_memory_bank(
self,
memory_bank_id: str,
provider_id: str,
provider_memorybank_id: str,
params: BankParams,
memory_bank_type: MemoryBankType,
provider_id: Optional[str] = None,
provider_memorybank_id: Optional[str] = None,
params: Optional[BankParams] = None,
) -> MemoryBank:
if provider_memorybank_id is None:
provider_memorybank_id = memory_bank_id
@ -289,7 +290,11 @@ class MemoryBanksRoutingTable(CommonRoutingTableImpl, MemoryBanks):
"No provider specified and multiple providers available. Please specify a provider_id."
)
memory_bank = build_memory_bank(
memory_bank_id, params.type, provider_id, provider_memorybank_id, params
memory_bank_id,
memory_bank_type,
provider_id,
provider_memorybank_id,
params,
)
await self.register_object(memory_bank)
return memory_bank

View file

@ -25,7 +25,7 @@ def build_memory_bank(
provider_memorybank_id: str,
params: Optional[BankParams] = None,
) -> MemoryBank:
if memory_bank_type == MemoryBankType.vector:
if memory_bank_type == MemoryBankType.vector.value:
assert isinstance(params, VectorMemoryBankParams)
memory_bank = VectorMemoryBank(
identifier=memory_bank_id,
@ -36,21 +36,21 @@ def build_memory_bank(
chunk_size_in_tokens=params.chunk_size_in_tokens,
overlap_size_in_tokens=params.overlap_size_in_tokens,
)
elif memory_bank_type == MemoryBankType.keyvalue:
elif memory_bank_type == MemoryBankType.keyvalue.value:
memory_bank = KeyValueMemoryBank(
identifier=memory_bank_id,
provider_id=provider_id,
provider_resource_id=provider_memorybank_id,
memory_bank_type=memory_bank_type,
)
elif memory_bank_type == MemoryBankType.keyword:
elif memory_bank_type == MemoryBankType.keyword.value:
memory_bank = KeywordMemoryBank(
identifier=memory_bank_id,
provider_id=provider_id,
provider_resource_id=provider_memorybank_id,
memory_bank_type=memory_bank_type,
)
elif memory_bank_type == MemoryBankType.graph:
elif memory_bank_type == MemoryBankType.graph.value:
memory_bank = GraphMemoryBank(
identifier=memory_bank_id,
provider_id=provider_id,