mirror of
https://github.com/meta-llama/llama-stack.git
synced 2025-12-21 14:22:25 +00:00
ci: record-if-missing when coming from stainless (#4408)
# What does this PR do?
we will typically need to record the missing json for net new APIs. use
record-if-missing so that the integration tests can re-record and commit
the files to the PR
set the stainless inference mode to record-if-missing, and properly pass
the pr_head_sha on workflow_call.
## Test Plan
see 2031824567
which uses this commit.
Signed-off-by: Charlie Doern <cdoern@redhat.com>
This commit is contained in:
parent
2d149e3d2d
commit
5d52cb28c2
4 changed files with 13 additions and 4 deletions
|
|
@ -62,7 +62,7 @@ runs:
|
||||||
|
|
||||||
|
|
||||||
- name: Commit and push recordings
|
- name: Commit and push recordings
|
||||||
if: ${{ inputs.inference-mode == 'record' }}
|
if: ${{ inputs.inference-mode == 'record' || inputs.inference-mode == 'record-if-missing' }}
|
||||||
shell: bash
|
shell: bash
|
||||||
run: |
|
run: |
|
||||||
echo "Checking for recording changes"
|
echo "Checking for recording changes"
|
||||||
|
|
|
||||||
12
.github/workflows/integration-tests.yml
vendored
12
.github/workflows/integration-tests.yml
vendored
|
|
@ -48,6 +48,10 @@ on:
|
||||||
type: string
|
type: string
|
||||||
default: 'default'
|
default: 'default'
|
||||||
description: 'Matrix configuration key from ci_matrix.json (e.g., "default", "stainless")'
|
description: 'Matrix configuration key from ci_matrix.json (e.g., "default", "stainless")'
|
||||||
|
pr_head_sha:
|
||||||
|
required: false
|
||||||
|
type: string
|
||||||
|
description: 'The SHA of the pull request head to checkout'
|
||||||
test-all-client-versions:
|
test-all-client-versions:
|
||||||
required: false
|
required: false
|
||||||
type: boolean
|
type: boolean
|
||||||
|
|
@ -67,6 +71,8 @@ jobs:
|
||||||
steps:
|
steps:
|
||||||
- name: Checkout repository
|
- name: Checkout repository
|
||||||
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
|
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
|
||||||
|
with:
|
||||||
|
ref: ${{ inputs.pr_head_sha || github.event.pull_request.head.sha || github.sha }}
|
||||||
|
|
||||||
- name: Generate test matrix
|
- name: Generate test matrix
|
||||||
id: set-matrix
|
id: set-matrix
|
||||||
|
|
@ -100,6 +106,8 @@ jobs:
|
||||||
steps:
|
steps:
|
||||||
- name: Checkout repository
|
- name: Checkout repository
|
||||||
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
|
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
|
||||||
|
with:
|
||||||
|
ref: ${{ inputs.pr_head_sha || github.event.pull_request.head.sha || github.sha }}
|
||||||
|
|
||||||
- name: Setup test environment
|
- name: Setup test environment
|
||||||
if: ${{ matrix.config.allowed_clients == null || contains(matrix.config.allowed_clients, matrix.client) }}
|
if: ${{ matrix.config.allowed_clients == null || contains(matrix.config.allowed_clients, matrix.client) }}
|
||||||
|
|
@ -110,7 +118,7 @@ jobs:
|
||||||
sdk_install_url: ${{ inputs.sdk_install_url || '' }}
|
sdk_install_url: ${{ inputs.sdk_install_url || '' }}
|
||||||
setup: ${{ matrix.config.setup }}
|
setup: ${{ matrix.config.setup }}
|
||||||
suite: ${{ matrix.config.suite }}
|
suite: ${{ matrix.config.suite }}
|
||||||
inference-mode: 'replay'
|
inference-mode: ${{ matrix.config.inference_mode || 'replay' }}
|
||||||
|
|
||||||
- name: Setup Node.js for TypeScript client tests
|
- name: Setup Node.js for TypeScript client tests
|
||||||
if: ${{ matrix.client == 'server' }}
|
if: ${{ matrix.client == 'server' }}
|
||||||
|
|
@ -140,5 +148,5 @@ jobs:
|
||||||
|| (matrix.client == 'server' && 'server:ci-tests')
|
|| (matrix.client == 'server' && 'server:ci-tests')
|
||||||
|| 'docker:ci-tests' }}
|
|| 'docker:ci-tests' }}
|
||||||
setup: ${{ matrix.config.setup }}
|
setup: ${{ matrix.config.setup }}
|
||||||
inference-mode: 'replay'
|
inference-mode: ${{ matrix.config.inference_mode || 'replay' }}
|
||||||
suite: ${{ matrix.config.suite }}
|
suite: ${{ matrix.config.suite }}
|
||||||
|
|
|
||||||
1
.github/workflows/stainless-builds.yml
vendored
1
.github/workflows/stainless-builds.yml
vendored
|
|
@ -181,6 +181,7 @@ jobs:
|
||||||
sdk_install_url: ${{ inputs.sdk_install_url || needs.preview.outputs.sdk_install_url }}
|
sdk_install_url: ${{ inputs.sdk_install_url || needs.preview.outputs.sdk_install_url }}
|
||||||
matrix_key: 'stainless'
|
matrix_key: 'stainless'
|
||||||
test-all-client-versions: false
|
test-all-client-versions: false
|
||||||
|
pr_head_sha: ${{ needs.compute-branch.outputs.pr_head_sha }}
|
||||||
|
|
||||||
merge:
|
merge:
|
||||||
needs: compute-branch
|
needs: compute-branch
|
||||||
|
|
|
||||||
|
|
@ -7,7 +7,7 @@
|
||||||
{"suite": "base-vllm-subset", "setup": "vllm"}
|
{"suite": "base-vllm-subset", "setup": "vllm"}
|
||||||
],
|
],
|
||||||
"stainless": [
|
"stainless": [
|
||||||
{"suite": "base", "setup": "ollama", "allowed_clients": ["library"]}
|
{"suite": "base", "setup": "ollama", "allowed_clients": ["library"], "inference_mode": "record-if-missing"}
|
||||||
],
|
],
|
||||||
"schedules": {
|
"schedules": {
|
||||||
"1 0 * * 0": [
|
"1 0 * * 0": [
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue