phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-10-04 04:04:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

chore: handle missing finish_reason (#3328)
Some checks failed
SqlStore Integration Tests / test-postgres (3.13) (push) Failing after 1s
Details
Integration Auth Tests / test-matrix (oauth2_token) (push) Failing after 2s
Details
Test External Providers Installed via Module / test-external-providers-from-module (venv) (push) Has been skipped
Details
SqlStore Integration Tests / test-postgres (3.12) (push) Failing after 3s
Details
Python Package Build Test / build (3.13) (push) Failing after 3s
Details
Integration Tests (Replay) / Integration Tests (, , , client=, vision=) (push) Failing after 5s
Details
Python Package Build Test / build (3.12) (push) Failing after 4s
Details
Test External API and Providers / test-external (venv) (push) Failing after 4s
Details
Vector IO Integration Tests / test-matrix (push) Failing after 7s
Details
Unit Tests / unit-tests (3.13) (push) Failing after 4s
Details
Unit Tests / unit-tests (3.12) (push) Failing after 5s
Details
UI Tests / ui-tests (22) (push) Successful in 34s
Details
Pre-commit / pre-commit (push) Successful in 1m25s
Details

Browse source 
# What does this PR do?
Sometimes the stream don't have chunks with finish_reason, e.g. canceled
stream, which throws a pydantic error as OpenAIChoice.finish_reason: str

## Test Plan
observe no more such error when benchmarking
This commit is contained in:
ehhuang 2025-09-04 04:23:18 -07:00 • committed by GitHub
parent 02f6e0f531
commit 5d52e0d2c5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
llama_stack/core/routers/inference.py
View file

@ -755,7 +755,7 @@ class InferenceRouter(Inference):
choices_data[idx] = { choices_data[idx] = {
"content_parts": [], "content_parts": [],
"tool_calls_builder": {}, "tool_calls_builder": {},
"finish_reason": None, "finish_reason": "stop",
"logprobs_content_parts": [], "logprobs_content_parts": [],
} }
current_choice_data = choices_data[idx] current_choice_data = choices_data[idx]