From 5dbe0c5b76e49eb7cfb7ccd7ce4d29f8017ce709 Mon Sep 17 00:00:00 2001 From: Charlie Doern Date: Thu, 2 Oct 2025 07:49:10 -0400 Subject: [PATCH] fix: re-enable conformance skipping ability this was broken by #3631, re-enable this ability by only using oasdiff when .skip != 'true' Signed-off-by: Charlie Doern --- .github/workflows/conformance.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/conformance.yml b/.github/workflows/conformance.yml index 2dd62a9c4..5bbd53e5f 100644 --- a/.github/workflows/conformance.yml +++ b/.github/workflows/conformance.yml @@ -96,6 +96,7 @@ jobs: # Verify API specs exist for conformance testing - name: Check API Specs + if: steps.skip-check.outputs.skip != 'true' run: | echo "Checking for API specification files..." @@ -134,10 +135,10 @@ jobs: - name: Run OpenAPI Breaking Change Diff if: steps.skip-check.outputs.skip != 'true' run: | - oasdiff breaking --fail-on ERR base/docs/static/llama-stack-spec.yaml docs/static/llama-stack-spec.yaml --match-path '^/v1/' + oasdiff breaking --fail-on ERR $BASE_SPEC $CURRENT_SPEC --match-path '^/v1/' # Report when test is skipped - name: Report skip reason if: steps.skip-check.outputs.skip == 'true' run: | - oasdiff breaking --fail-on ERR $BASE_SPEC $CURRENT_SPEC --match-path '^/v1/' + echo "Conformance test skipped due to breaking change indicator"