phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-12-03 01:48:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

raise when querying without config

Browse source 
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
This commit is contained in:
Francisco Javier Arceo 2025-11-25 23:24:07 -05:00
parent a57a77af20
commit 5ec6f5dcff
2 changed files with 6 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/llama_stack/providers/utils/memory/vector_store.py
View file

@ -296,8 +296,9 @@ class VectorStoreWithIndex:
async def _rewrite_query_for_file_search(self, query: str) -> str:
"""Rewrite a search query using the globally configured LLM model for better retrieval results."""
if not rewrite_query_config._DEFAULT_REWRITE_QUERY_MODEL:
log.debug("No default query rewriting model configured, using original query")
return query
raise ValueError(
"Query rewriting requested but not configured. Please configure rewrite_query_params.model in vector_stores config."
)
model_id = f"{rewrite_query_config._DEFAULT_REWRITE_QUERY_MODEL.provider_id}/{rewrite_query_config._DEFAULT_REWRITE_QUERY_MODEL.model_id}"

12
tests/unit/providers/vector_io/test_vector_io_openai_vector_stores.py
View file

@ -1325,7 +1325,7 @@ async def test_query_expansion_functionality(vector_io_adapter):
assert chat_call_args.max_tokens == 150
assert chat_call_args.temperature == 0.7
# Test 2: No query expansion when no global model is configured
# Test 2: Error when query rewriting is requested but no global model is configured
mock_inference_api.reset_mock()
mock_index.reset_mock()
@ -1333,14 +1333,8 @@ async def test_query_expansion_functionality(vector_io_adapter):
set_default_rewrite_query_config(None)
params = {"rewrite_query": True, "max_chunks": 5}
result2 = await vector_store_with_index.query_chunks("test query", params)
# Verify chat completion was NOT called
mock_inference_api.openai_chat_completion.assert_not_called()
# But normal flow should still work
mock_inference_api.openai_embeddings.assert_called_once()
mock_index.query_vector.assert_called_once()
assert result2 == mock_response
with pytest.raises(ValueError, match="Query rewriting requested but not configured"):
await vector_store_with_index.query_chunks("test query", params)
# Test 3: Normal behavior without rewrite_query parameter
mock_inference_api.reset_mock()