phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-08-21 09:23:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: disable ui-prettier & ui-eslint (#3207)

Browse source
This commit is contained in:
Matthew Farrellee 2025-08-20 05:42:43 -05:00 • committed by GitHub
parent 5f6d5072b6
commit 5f151ddf45
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 38 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

22
.github/workflows/pre-commit.yml vendored
View file

@ -36,16 +36,20 @@ jobs:
**/requirements*.txt **/requirements*.txt
.pre-commit-config.yaml .pre-commit-config.yaml
- name: Set up Node.js # npm ci may fail -
uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0 # npm error `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
with: # npm error Invalid: lock file's llama-stack-client@0.2.17 does not satisfy llama-stack-client@0.2.18
node-version: '20'
cache: 'npm'
cache-dependency-path: 'llama_stack/ui/'
- name: Install npm dependencies # - name: Set up Node.js
run: npm ci # uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
working-directory: llama_stack/ui # with:
# node-version: '20'
# cache: 'npm'
# cache-dependency-path: 'llama_stack/ui/'
# - name: Install npm dependencies
# run: npm ci
# working-directory: llama_stack/ui
- uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd # v3.0.1 - uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd # v3.0.1
continue-on-error: true continue-on-error: true

39
.pre-commit-config.yaml
View file

@ -146,20 +146,31 @@ repos:
pass_filenames: false pass_filenames: false
require_serial: true require_serial: true
files: ^.github/workflows/.*$ files: ^.github/workflows/.*$
- id: ui-prettier # ui-prettier and ui-eslint are disabled until we can avoid `npm ci`, which is slow and may fail -
name: Format UI code with Prettier # npm error `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
entry: bash -c 'cd llama_stack/ui && npm ci && npm run format' # npm error Invalid: lock file's llama-stack-client@0.2.17 does not satisfy llama-stack-client@0.2.18
language: system # and until we have infra for installing prettier and next via npm -
files: ^llama_stack/ui/.*\.(ts|tsx)$ # Lint UI code with ESLint.....................................................Failed
pass_filenames: false # - hook id: ui-eslint
require_serial: true # - exit code: 127
- id: ui-eslint # > ui@0.1.0 lint
name: Lint UI code with ESLint # > next lint --fix --quiet
entry: bash -c 'cd llama_stack/ui && npm run lint -- --fix --quiet' # sh: line 1: next: command not found
language: system #
files: ^llama_stack/ui/.*\.(ts|tsx)$ # - id: ui-prettier
pass_filenames: false # name: Format UI code with Prettier
require_serial: true # entry: bash -c 'cd llama_stack/ui && npm ci && npm run format'
# language: system
# files: ^llama_stack/ui/.*\.(ts|tsx)$
# pass_filenames: false
# require_serial: true
# - id: ui-eslint
# name: Lint UI code with ESLint
# entry: bash -c 'cd llama_stack/ui && npm run lint -- --fix --quiet'
# language: system
# files: ^llama_stack/ui/.*\.(ts|tsx)$
# pass_filenames: false
# require_serial: true
ci: ci:
autofix_commit_msg: 🎨 [pre-commit.ci] Auto format from pre-commit.com hooks autofix_commit_msg: 🎨 [pre-commit.ci] Auto format from pre-commit.com hooks