phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-12-03 09:53:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: actualize chunking strategy in vector store create API

Browse source 
# What does this PR do?


## Test Plan
This commit is contained in:
Eric Huang 2025-11-05 13:52:54 -08:00
parent d9cf5cd480
commit 6097d93294
3 changed files with 13 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/llama_stack/core/routers/vector_io.py
View file

@ -20,6 +20,8 @@ from llama_stack.apis.vector_io import (
SearchRankingOptions, SearchRankingOptions,
VectorIO, VectorIO,
VectorStoreChunkingStrategy, VectorStoreChunkingStrategy,
VectorStoreChunkingStrategyStatic,
VectorStoreChunkingStrategyStaticConfig,
VectorStoreDeleteResponse, VectorStoreDeleteResponse,
VectorStoreFileBatchObject, VectorStoreFileBatchObject,
VectorStoreFileContentsResponse, VectorStoreFileContentsResponse,
@ -167,6 +169,13 @@ class VectorIORouter(VectorIO):
if embedding_dimension is not None: if embedding_dimension is not None:
params.model_extra["embedding_dimension"] = embedding_dimension params.model_extra["embedding_dimension"] = embedding_dimension
# Set chunking strategy explicitly if not provided
if params.chunking_strategy is None or params.chunking_strategy.type == "auto":
# actualize the chunking strategy to static
params.chunking_strategy = VectorStoreChunkingStrategyStatic(
static=VectorStoreChunkingStrategyStaticConfig()
)
return await provider.openai_create_vector_store(params) return await provider.openai_create_vector_store(params)
async def openai_list_vector_stores( async def openai_list_vector_stores(

2
src/llama_stack/providers/utils/memory/openai_vector_store_mixin.py
View file

@ -426,7 +426,7 @@ class OpenAIVectorStoreMixin(ABC):
"expires_at": None, "expires_at": None,
"last_active_at": created_at, "last_active_at": created_at,
"file_ids": [], "file_ids": [],
"chunking_strategy": params.chunking_strategy, "chunking_strategy": params.chunking_strategy.model_dump(),
} }
# Add provider information to metadata if provided # Add provider information to metadata if provided

6
tests/integration/vector_io/test_openai_vector_stores.py
View file

@ -679,7 +679,7 @@ def test_openai_vector_store_attach_file(
assert file_attach_response.id == file.id assert file_attach_response.id == file.id
assert file_attach_response.vector_store_id == vector_store.id assert file_attach_response.vector_store_id == vector_store.id
assert file_attach_response.status == "completed" assert file_attach_response.status == "completed"
assert file_attach_response.chunking_strategy.type == "auto" assert file_attach_response.chunking_strategy.type == "static"
assert file_attach_response.created_at > 0 assert file_attach_response.created_at > 0
assert not file_attach_response.last_error assert not file_attach_response.last_error
@ -815,8 +815,8 @@ def test_openai_vector_store_list_files(
assert set(file_ids) == {file.id for file in files_list.data} assert set(file_ids) == {file.id for file in files_list.data}
assert files_list.data[0].object == "vector_store.file" assert files_list.data[0].object == "vector_store.file"
assert files_list.data[0].vector_store_id == vector_store.id assert files_list.data[0].vector_store_id == vector_store.id
assert files_list.data[0].status == "completed" assert files_list.data[0].status in ["completed", "in_progress"]
assert files_list.data[0].chunking_strategy.type == "auto" assert files_list.data[0].chunking_strategy.type == "static"
assert files_list.data[0].created_at > 0 assert files_list.data[0].created_at > 0
assert files_list.first_id == files_list.data[0].id assert files_list.first_id == files_list.data[0].id
assert not files_list.data[0].last_error assert not files_list.data[0].last_error