From 6408bdbc9d8ff4e7ce1c5ee4ca0a2745bdb88594 Mon Sep 17 00:00:00 2001 From: Xi Yan Date: Wed, 12 Mar 2025 21:09:17 -0700 Subject: [PATCH] scoring fn id --- llama_stack/apis/benchmarks/benchmarks.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/llama_stack/apis/benchmarks/benchmarks.py b/llama_stack/apis/benchmarks/benchmarks.py index 6738a6653..01fc873e6 100644 --- a/llama_stack/apis/benchmarks/benchmarks.py +++ b/llama_stack/apis/benchmarks/benchmarks.py @@ -20,7 +20,7 @@ class CommonBenchmarkFields(BaseModel): """ dataset_id: str - scoring_functions: List[ScoringFnParams] + scoring_fn_ids: List[str] metadata: Dict[str, Any] = Field( default_factory=dict, description="Metadata for this benchmark", @@ -65,7 +65,7 @@ class Benchmarks(Protocol): async def register_benchmark( self, dataset_id: str, - scoring_functions: List[ScoringFnParams], + scoring_fn_ids: List[str], benchmark_id: Optional[str] = None, metadata: Optional[Dict[str, Any]] = None, ) -> Benchmark: @@ -73,7 +73,7 @@ class Benchmarks(Protocol): Register a new benchmark. :param dataset_id: The ID of the dataset to used to run the benchmark. - :param scoring_functions: The scoring functions with parameters to use for this benchmark. + :param scoring_fn_ids: List of scoring function ids to use for this benchmark. :param benchmark_id: (Optional) The ID of the benchmark to register. If not provided, a random ID will be generated. :param metadata: (Optional) Metadata for this benchmark for additional descriptions. """