phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-10-04 12:07:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat: Add items and title to ToolParameter/ToolParamDefinition (#3003)
Some checks failed
SqlStore Integration Tests / test-postgres (3.12) (push) Failing after 0s
Details
Test External Providers Installed via Module / test-external-providers-from-module (venv) (push) Has been skipped
Details
SqlStore Integration Tests / test-postgres (3.13) (push) Failing after 17s
Details
Python Package Build Test / build (3.12) (push) Failing after 17s
Details
Integration Tests (Replay) / Integration Tests (, , , client=, ) (push) Failing after 19s
Details
Unit Tests / unit-tests (3.13) (push) Failing after 15s
Details
Vector IO Integration Tests / test-matrix (push) Failing after 20s
Details
Test External API and Providers / test-external (venv) (push) Failing after 3s
Details
Integration Auth Tests / test-matrix (oauth2_token) (push) Failing after 19s
Details
Python Package Build Test / build (3.13) (push) Failing after 16s
Details
Unit Tests / unit-tests (3.12) (push) Failing after 16s
Details
API Conformance Tests / check-schema-compatibility (push) Successful in 25s
Details
UI Tests / ui-tests (22) (push) Successful in 50s
Details
Pre-commit / pre-commit (push) Successful in 1m16s
Details

Browse source 
# What does this PR do?
<!-- Provide a short summary of what this PR does and why. Link to
relevant issues if applicable. -->
Add items and title to ToolParameter/ToolParamDefinition. Adding items
will resolve the issue that occurs with Gemini LLM when an MCP tool has
array-type properties.

<!-- If resolving an issue, uncomment and update the line below -->
<!-- Closes #[issue-number] -->

## Test Plan
<!-- Describe the tests you ran to verify your changes with result
summaries. *Provide clear instructions so the plan can be easily
re-executed.* -->
Unite test cases will be added.

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kai Wu <kaiwu@meta.com>
Co-authored-by: Ashwin Bharambe <ashwin.bharambe@gmail.com>
This commit is contained in:
Tami Takamiya 2025-09-27 14:35:29 -04:00 • committed by GitHub
parent 1a8d3ed315
commit 65f7b81e98
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
16 changed files with 1835 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

4
llama_stack/providers/inline/agents/meta_reference/agent_instance.py
View file

@ -798,6 +798,8 @@ class ChatAgent(ShieldRunnerMixin):
param_type=param.parameter_type,
description=param.description,
required=param.required,
items=param.items,
title=param.title,
default=param.default,
)
for param in tool_def.parameters
@ -841,6 +843,8 @@ class ChatAgent(ShieldRunnerMixin):
param_type=param.parameter_type,
description=param.description,
required=param.required,
items=param.items,
title=param.title,
default=param.default,
)
for param in tool_def.parameters