feat: remove usage of build yaml (#4192)

# What does this PR do?

the build.yaml is only used in the following ways:

1. list-deps
2. distribution code-gen

since `llama stack build` no longer exists, I found myself asking "why
do we need two different files for list-deps and run"?

Removing the BuildConfig and altering the usage of the
DistributionTemplate in llama stack list-deps is the first step in
removing the build yaml entirely.

Removing the BuildConfig and build.yaml cuts the files users need to
maintain in half, and allows us to focus on the stability of _just_ the
run.yaml

This PR removes the build.yaml, BuildConfig datatype, and its usage
throughout the codebase. Users are now expected to point to run.yaml
files when running list-deps, and our codebase automatically uses these
types now for things like `get_provider_registry`.

**Additionally, two renames: `StackRunConfig` -> `StackConfig` and
`run.yaml` -> `config.yaml`.**

The build.yaml made sense for when we were managing the build process
for the user and actually _producing_ a run.yaml _from_ the build.yaml,
but now that we are simply just getting the provider registry and
listing the deps, switching to config.yaml simplifies the scope here
greatly.

## Test Plan

existing list-deps usage should work in the tests.

---------

Signed-off-by: Charlie Doern <cdoern@redhat.com>

tests/unit/distribution/test_distribution.py

@@ -11,7 +11,7 @@ import pytest
 import yaml
 from pydantic import BaseModel, Field, ValidationError
 
-from llama_stack.core.datatypes import Api, Provider, StackRunConfig
+from llama_stack.core.datatypes import Api, Provider, StackConfig
 from llama_stack.core.distribution import INTERNAL_APIS, get_provider_registry, providable_apis
 from llama_stack.core.storage.datatypes import (
     InferenceStoreReference,
@@ -53,7 +53,7 @@ def _default_storage() -> StorageConfig:
     )
 
 
-def make_stack_config(**overrides) -> StackRunConfig:
+def make_stack_config(**overrides) -> StackConfig:
     storage = overrides.pop("storage", _default_storage())
     defaults = dict(
         image_name="test_image",
@@ -62,7 +62,7 @@ def make_stack_config(**overrides) -> StackRunConfig:
         storage=storage,
     )
     defaults.update(overrides)
-    return StackRunConfig(**defaults)
+    return StackConfig(**defaults)
 
 
 @pytest.fixture
@@ -270,7 +270,7 @@ class TestProviderRegistry:
             external_providers_dir="/nonexistent/dir",
         )
         with pytest.raises(FileNotFoundError):
-            get_provider_registry(config)
+            get_provider_registry(config=config)
 
     def test_empty_api_directory(self, api_directories, mock_providers, base_config):
         """Test handling of empty API directory."""
@@ -339,7 +339,7 @@ pip_packages:
                     ]
                 },
             )
-            registry = get_provider_registry(config)
+            registry = get_provider_registry(config=config)
             assert Api.inference in registry
             assert "external_test" in registry[Api.inference]
             provider = registry[Api.inference]["external_test"]
@@ -368,7 +368,7 @@ pip_packages:
                 },
             )
             with pytest.raises(ValueError) as exc_info:
-                get_provider_registry(config)
+                get_provider_registry(config=config)
             assert "get_provider_spec not found" in str(exc_info.value)
 
     def test_external_provider_from_module_missing_get_provider_spec(self, mock_providers):
@@ -391,31 +391,29 @@ pip_packages:
                 },
             )
             with pytest.raises(AttributeError):
-                get_provider_registry(config)
+                get_provider_registry(config=config)
 
-    def test_external_provider_from_module_building(self, mock_providers):
-        """Test loading an external provider from a module during build (building=True, partial spec)."""
-        from llama_stack.core.datatypes import BuildConfig, BuildProvider, DistributionSpec
+    def test_external_provider_from_module_listing(self, mock_providers):
+        """Test loading an external provider from a module during list-deps (listing=True, partial spec)."""
+        from llama_stack.core.datatypes import StackConfig
         from llama_stack_api import Api
 
-        # No importlib patch needed, should not import module when type of `config` is BuildConfig or DistributionSpec
-        build_config = BuildConfig(
-            version=2,
-            image_type="container",
+        # No importlib patch needed, should not import module when listing
+        config = StackConfig(
             image_name="test_image",
-            distribution_spec=DistributionSpec(
-                description="test",
-                providers={
-                    "inference": [
-                        BuildProvider(
-                            provider_type="external_test",
-                            module="external_test",
-                        )
-                    ]
-                },
-            ),
+            apis=[],
+            providers={
+                "inference": [
+                    Provider(
+                        provider_id="external_test",
+                        provider_type="external_test",
+                        config={},
+                        module="external_test",
+                    )
+                ]
+            },
         )
-        registry = get_provider_registry(build_config)
+        registry = get_provider_registry(config=config, listing=True)
         assert Api.inference in registry
         assert "external_test" in registry[Api.inference]
         provider = registry[Api.inference]["external_test"]
@@ -448,7 +446,7 @@ class TestGetExternalProvidersFromModule:
                 },
             )
             registry = {Api.inference: {}}
-            result = get_external_providers_from_module(registry, config, building=False)
+            result = get_external_providers_from_module(registry, config, listing=False)
             # Should not add anything to registry
             assert len(result[Api.inference]) == 0
 
@@ -487,36 +485,34 @@ class TestGetExternalProvidersFromModule:
                 },
             )
             registry = {Api.inference: {}}
-            result = get_external_providers_from_module(registry, config, building=False)
+            result = get_external_providers_from_module(registry, config, listing=False)
             assert "versioned_test" in result[Api.inference]
             assert result[Api.inference]["versioned_test"].module == "versioned_test==1.0.0"
 
     def test_buildconfig_does_not_import_module(self, mock_providers):
-        """Test that BuildConfig does not import the module (building=True)."""
-        from llama_stack.core.datatypes import BuildConfig, BuildProvider, DistributionSpec
+        """Test that StackConfig does not import the module when listing (listing=True)."""
+        from llama_stack.core.datatypes import StackConfig
         from llama_stack.core.distribution import get_external_providers_from_module
 
-        build_config = BuildConfig(
-            version=2,
-            image_type="container",
+        config = StackConfig(
             image_name="test_image",
-            distribution_spec=DistributionSpec(
-                description="test",
-                providers={
-                    "inference": [
-                        BuildProvider(
-                            provider_type="build_test",
-                            module="build_test==1.0.0",
-                        )
-                    ]
-                },
-            ),
+            apis=[],
+            providers={
+                "inference": [
+                    Provider(
+                        provider_id="build_test",
+                        provider_type="build_test",
+                        config={},
+                        module="build_test==1.0.0",
+                    )
+                ]
+            },
         )
 
-        # Should not call import_module at all when building
+        # Should not call import_module at all when listing
         with patch("importlib.import_module") as mock_import:
             registry = {Api.inference: {}}
-            result = get_external_providers_from_module(registry, build_config, building=True)
+            result = get_external_providers_from_module(registry, config, listing=True)
 
             # Verify module was NOT imported
             mock_import.assert_not_called()
@@ -530,35 +526,31 @@ class TestGetExternalProvidersFromModule:
             assert provider.api == Api.inference
 
     def test_buildconfig_multiple_providers(self, mock_providers):
-        """Test BuildConfig with multiple providers for the same API."""
-        from llama_stack.core.datatypes import BuildConfig, BuildProvider, DistributionSpec
+        """Test StackConfig with multiple providers for the same API."""
+        from llama_stack.core.datatypes import StackConfig
         from llama_stack.core.distribution import get_external_providers_from_module
 
-        build_config = BuildConfig(
-            version=2,
-            image_type="container",
+        config = StackConfig(
             image_name="test_image",
-            distribution_spec=DistributionSpec(
-                description="test",
-                providers={
-                    "inference": [
-                        BuildProvider(provider_type="provider1", module="provider1"),
-                        BuildProvider(provider_type="provider2", module="provider2"),
-                    ]
-                },
-            ),
+            apis=[],
+            providers={
+                "inference": [
+                    Provider(provider_id="provider1", provider_type="provider1", config={}, module="provider1"),
+                    Provider(provider_id="provider2", provider_type="provider2", config={}, module="provider2"),
+                ]
+            },
         )
 
         with patch("importlib.import_module") as mock_import:
             registry = {Api.inference: {}}
-            result = get_external_providers_from_module(registry, build_config, building=True)
+            result = get_external_providers_from_module(registry, config, listing=True)
 
             mock_import.assert_not_called()
             assert "provider1" in result[Api.inference]
             assert "provider2" in result[Api.inference]
 
     def test_distributionspec_does_not_import_module(self, mock_providers):
-        """Test that DistributionSpec does not import the module (building=True)."""
+        """Test that DistributionSpec does not import the module (listing=True)."""
         from llama_stack.core.datatypes import BuildProvider, DistributionSpec
         from llama_stack.core.distribution import get_external_providers_from_module
 
@@ -574,10 +566,10 @@ class TestGetExternalProvidersFromModule:
             },
         )
 
-        # Should not call import_module at all when building
+        # Should not call import_module at all when listing
         with patch("importlib.import_module") as mock_import:
             registry = {Api.inference: {}}
-            result = get_external_providers_from_module(registry, dist_spec, building=True)
+            result = get_external_providers_from_module(registry, dist_spec, listing=True)
 
             # Verify module was NOT imported
             mock_import.assert_not_called()
@@ -631,7 +623,7 @@ class TestGetExternalProvidersFromModule:
                 },
             )
             registry = {Api.inference: {}}
-            result = get_external_providers_from_module(registry, config, building=False)
+            result = get_external_providers_from_module(registry, config, listing=False)
 
             # Only the matching provider_type should be added
             assert "list_test" in result[Api.inference]
@@ -679,7 +671,7 @@ class TestGetExternalProvidersFromModule:
                 },
             )
             registry = {Api.inference: {}}
-            result = get_external_providers_from_module(registry, config, building=False)
+            result = get_external_providers_from_module(registry, config, listing=False)
 
             # Only the matching provider_type should be added
             assert "wanted" in result[Api.inference]
@@ -734,7 +726,7 @@ class TestGetExternalProvidersFromModule:
                 },
             )
             registry = {Api.inference: {}}
-            result = get_external_providers_from_module(registry, config, building=False)
+            result = get_external_providers_from_module(registry, config, listing=False)
 
             # Both provider types should be added to registry
             assert "remote::ollama" in result[Api.inference]
@@ -768,7 +760,7 @@ class TestGetExternalProvidersFromModule:
             registry = {Api.inference: {}}
 
             with pytest.raises(ValueError) as exc_info:
-                get_external_providers_from_module(registry, config, building=False)
+                get_external_providers_from_module(registry, config, listing=False)
 
             assert "get_provider_spec not found" in str(exc_info.value)
 
@@ -805,7 +797,7 @@ class TestGetExternalProvidersFromModule:
             registry = {Api.inference: {}}
 
             with pytest.raises(RuntimeError) as exc_info:
-                get_external_providers_from_module(registry, config, building=False)
+                get_external_providers_from_module(registry, config, listing=False)
 
             assert "Something went wrong" in str(exc_info.value)
 
@@ -818,7 +810,7 @@ class TestGetExternalProvidersFromModule:
             providers={},
         )
         registry = {Api.inference: {}}
-        result = get_external_providers_from_module(registry, config, building=False)
+        result = get_external_providers_from_module(registry, config, listing=False)
 
         # Should return registry unchanged
         assert result == registry
@@ -874,7 +866,7 @@ class TestGetExternalProvidersFromModule:
                 },
             )
             registry = {Api.inference: {}, Api.safety: {}}
-            result = get_external_providers_from_module(registry, config, building=False)
+            result = get_external_providers_from_module(registry, config, listing=False)
 
             assert "inf_test" in result[Api.inference]
             assert "safe_test" in result[Api.safety]