phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-12-06 10:37:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: access control to fail-closed when owner attributes are missing (#4273)
Some checks failed
SqlStore Integration Tests / test-postgres (3.12) (push) Failing after 0s
Details
Integration Auth Tests / test-matrix (oauth2_token) (push) Failing after 1s
Details
SqlStore Integration Tests / test-postgres (3.13) (push) Failing after 1s
Details
Test External Providers Installed via Module / test-external-providers-from-module (venv) (push) Has been skipped
Details
Integration Tests (Replay) / generate-matrix (push) Successful in 3s
Details
API Conformance Tests / check-schema-compatibility (push) Successful in 10s
Details
Python Package Build Test / build (3.12) (push) Successful in 16s
Details
Python Package Build Test / build (3.13) (push) Successful in 17s
Details
Vector IO Integration Tests / test-matrix (push) Failing after 35s
Details
UI Tests / ui-tests (22) (push) Successful in 39s
Details
Test External API and Providers / test-external (venv) (push) Failing after 44s
Details
Unit Tests / unit-tests (3.13) (push) Failing after 1m26s
Details
Unit Tests / unit-tests (3.12) (push) Failing after 1m28s
Details
Pre-commit / pre-commit (22) (push) Successful in 3m28s
Details
Integration Tests (Replay) / Integration Tests (, , , client=, ) (push) Failing after 3m12s
Details

Browse source
This commit is contained in:
Derek Higgins 2025-12-04 16:38:32 +00:00 • committed by GitHub
parent b4903d6766
commit 686065fe27
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 80 additions and 53 deletions
Download patch file Download diff file Expand all files Collapse all files

10
tests/integration/providers/utils/sqlstore/test_authorized_sqlstore.py
View file

@ -184,6 +184,16 @@ async def test_authorized_store_attributes(mock_get_authenticated_user, authoriz
f"Category missing logic failed: expected 4,5 but got {category_test_ids}"
)
# Test a user that has all roles and teams (should generate SQL)
# owner_principal = ''
# owner_principal = 'super-user'
# ((JSON_EXTRACT(access_attributes, '$.roles') LIKE '%"admin"%') OR (JSON_EXTRACT(access_attributes, '$.roles') LIKE '%"user"%'))
# ((JSON_EXTRACT(access_attributes, '$.teams') LIKE '%"dev"%') OR (JSON_EXTRACT(access_attributes, '$.teams') LIKE '%"qa"%'))
super_user = User("super-user", {"roles": ["admin", "user"], "teams": ["dev", "qa"]})
mock_get_authenticated_user.return_value = super_user
result = await authorized_store.fetch_all(table_name)
assert len(result.data) == 6
finally:
# Clean up records
await cleanup_records(authorized_store.sql_store, table_name, ["1", "2", "3", "4", "5", "6"])