phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-12-03 18:00:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: mypy

Browse source 
Signed-off-by: Sébastien Han <seb@redhat.com>
This commit is contained in:
Sébastien Han 2025-11-24 14:53:26 +01:00
parent a6aaf18bb6
commit 6d76a63eb7
No known key found for this signature in database
2 changed files with 13 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/llama_stack/core/server/fastapi_router_registry.py
View file

@ -21,7 +21,7 @@ if TYPE_CHECKING:
# Add new APIs here as they are migrated to the router system # Add new APIs here as they are migrated to the router system
from llama_stack_api.batches.fastapi_routes import create_router as create_batches_router from llama_stack_api.batches.fastapi_routes import create_router as create_batches_router
_ROUTER_FACTORIES: dict[str, APIRouter] = { _ROUTER_FACTORIES: dict[str, Any] = {
"batches": create_batches_router, "batches": create_batches_router,
} }

38
src/llama_stack_api/router_utils.py
View file

@ -46,16 +46,6 @@ def create_query_dependency[T: BaseModel](model_class: type[T]) -> Callable[...,
Returns: Returns:
A dependency function that can be used with FastAPI's Depends() A dependency function that can be used with FastAPI's Depends()
Example:
```python
get_list_batches_request = create_query_dependency(ListBatchesRequest)
@router.get("/batches")
async def list_batches(
request: Annotated[ListBatchesRequest, Depends(get_list_batches_request)]
):
...
``` ```
""" """
# Build function signature dynamically from model fields # Build function signature dynamically from model fields
@ -93,9 +83,12 @@ def create_query_dependency[T: BaseModel](model_class: type[T]) -> Callable[...,
) )
sig_params.append(param) sig_params.append(param)
dependency_func.__signature__ = inspect.Signature(sig_params) # These attributes are set dynamically at runtime. While mypy can't verify them statically,
dependency_func.__annotations__ = annotations # they are standard Python function attributes that exist on all callable objects at runtime.
dependency_func.__name__ = f"get_{model_class.__name__.lower()}_request" # Setting them allows FastAPI to properly introspect the function signature for dependency injection.
dependency_func.__signature__ = inspect.Signature(sig_params) # type: ignore[attr-defined]
dependency_func.__annotations__ = annotations # type: ignore[attr-defined]
dependency_func.__name__ = f"get_{model_class.__name__.lower()}_request" # type: ignore[attr-defined]
return dependency_func return dependency_func
@ -120,16 +113,6 @@ def create_path_dependency[T: BaseModel](model_class: type[T]) -> Callable[...,
Returns: Returns:
A dependency function that can be used with FastAPI's Depends() A dependency function that can be used with FastAPI's Depends()
Example:
```python
get_retrieve_batch_request = create_path_dependency(RetrieveBatchRequest)
@router.get("/batches/{batch_id}")
async def retrieve_batch(
request: Annotated[RetrieveBatchRequest, Depends(get_retrieve_batch_request)]
):
...
``` ```
""" """
# Get the single field from the model (path parameter models typically have one field) # Get the single field from the model (path parameter models typically have one field)
@ -162,8 +145,11 @@ def create_path_dependency[T: BaseModel](model_class: type[T]) -> Callable[...,
annotation=annotations[field_name], annotation=annotations[field_name],
) )
dependency_func.__signature__ = inspect.Signature([param]) # These attributes are set dynamically at runtime. While mypy can't verify them statically,
dependency_func.__annotations__ = annotations # they are standard Python function attributes that exist on all callable objects at runtime.
dependency_func.__name__ = f"get_{model_class.__name__.lower()}_request" # Setting them allows FastAPI to properly introspect the function signature for dependency injection.
dependency_func.__signature__ = inspect.Signature([param]) # type: ignore[attr-defined]
dependency_func.__annotations__ = annotations # type: ignore[attr-defined]
dependency_func.__name__ = f"get_{model_class.__name__.lower()}_request" # type: ignore[attr-defined]
return dependency_func return dependency_func