From 854c2ad264e9059f4d9b3d897734bbc8931ba359 Mon Sep 17 00:00:00 2001 From: Nathan Weinberg <31703736+nathan-weinberg@users.noreply.github.com> Date: Sat, 12 Apr 2025 04:19:11 -0400 Subject: [PATCH] fix: misleading help text for 'llama stack build' and 'llama stack run' (#1910) # What does this PR do? current text for 'llama stack build' and 'llama stack run' says that if no argument is passed to '--image-name' that the active Conda environment will be used in reality, the active enviroment is used whether it is from conda, virtualenv, etc. ## Test Plan N/A ## Documentation N/A Signed-off-by: Nathan Weinberg --- docs/source/distributions/building_distro.md | 2 +- llama_stack/cli/stack/build.py | 2 +- llama_stack/cli/stack/run.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/source/distributions/building_distro.md b/docs/source/distributions/building_distro.md index e1e38d7ce..ad5d3bff4 100644 --- a/docs/source/distributions/building_distro.md +++ b/docs/source/distributions/building_distro.md @@ -231,7 +231,7 @@ options: -h, --help show this help message and exit --port PORT Port to run the server on. It can also be passed via the env var LLAMA_STACK_PORT. (default: 8321) --image-name IMAGE_NAME - Name of the image to run. Defaults to the current conda environment (default: None) + Name of the image to run. Defaults to the current environment (default: None) --disable-ipv6 Disable IPv6 support (default: False) --env KEY=VALUE Environment variables to pass to the server in KEY=VALUE format. Can be specified multiple times. (default: []) --tls-keyfile TLS_KEYFILE diff --git a/llama_stack/cli/stack/build.py b/llama_stack/cli/stack/build.py index 0ada7c615..c511a0682 100644 --- a/llama_stack/cli/stack/build.py +++ b/llama_stack/cli/stack/build.py @@ -57,7 +57,7 @@ class StackBuild(Subcommand): type=str, help=textwrap.dedent( f"""[for image-type={"|".join(e.value for e in ImageType)}] Name of the conda or virtual environment to use for -the build. If not specified, currently active Conda environment will be used if found. +the build. If not specified, currently active environment will be used if found. """ ), default=None, diff --git a/llama_stack/cli/stack/run.py b/llama_stack/cli/stack/run.py index 92015187b..d8234bb46 100644 --- a/llama_stack/cli/stack/run.py +++ b/llama_stack/cli/stack/run.py @@ -45,7 +45,7 @@ class StackRun(Subcommand): "--image-name", type=str, default=os.environ.get("CONDA_DEFAULT_ENV"), - help="Name of the image to run. Defaults to the current conda environment", + help="Name of the image to run. Defaults to the current environment", ) self.parser.add_argument( "--disable-ipv6",