From 872f7eead0c425f8fb1e36cc0ecf3178bd3ef085 Mon Sep 17 00:00:00 2001 From: Yuan Tang Date: Thu, 27 Feb 2025 18:28:04 -0500 Subject: [PATCH] Address comments Signed-off-by: Yuan Tang --- .env.dev | 4 ---- .gitignore | 1 - CONTRIBUTING.md | 12 ++++++++++-- 3 files changed, 10 insertions(+), 7 deletions(-) delete mode 100644 .env.dev diff --git a/.env.dev b/.env.dev deleted file mode 100644 index 945485d0b..000000000 --- a/.env.dev +++ /dev/null @@ -1,4 +0,0 @@ -LLAMA_STACK_BASE_URL=http://localhost:8321 -LLAMA_STACK_CLIENT_LOG=debug -LLAMA_STACK_PORT=8321 -LLAMA_STACK_CONFIG= diff --git a/.gitignore b/.gitignore index cc9f374a8..f54d1563d 100644 --- a/.gitignore +++ b/.gitignore @@ -1,5 +1,4 @@ .env -.env.dev __pycache__ dist *.egg-info diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 17b28dda5..ef73dadc3 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -70,9 +70,17 @@ $ uv pip install -e . $ source .venv/bin/activate ``` -Note that you can modify the existing `.env.dev` dotenv file for running client SDK tests via the following: +Note that you can create a dotenv file `.env` that includes necessary environment variables: +``` +LLAMA_STACK_BASE_URL=http://localhost:8321 +LLAMA_STACK_CLIENT_LOG=debug +LLAMA_STACK_PORT=8321 +LLAMA_STACK_CONFIG= +``` + +And then use this dotenv file when running client SDK tests via the following: ```bash -$ uv run --env-file .env.dev -- pytest -v tests/client-sdk/inference/test_text_inference.py +$ uv run --env-file .env -- pytest -v tests/client-sdk/inference/test_text_inference.py ``` ## Pre-commit Hooks