From 8d8e90d78e1aaf711e828809641cc20ff5f570cd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Han?= Date: Mon, 30 Jun 2025 14:55:37 +0200 Subject: [PATCH] fix: add missing argument and methods (#2550) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit # What does this PR do? Resolves: ``` mypy.....................................................................Failed - hook id: mypy - exit code: 1 llama_stack/providers/utils/responses/responses_store.py:119: error: Missing positional argument "policy" in call to "fetch_one" of "AuthorizedSqlStore" [call-arg] llama_stack/providers/utils/responses/responses_store.py:122: error: "AuthorizedSqlStore" has no attribute "delete" [attr-defined] Found 2 errors in 1 file (checked 403 source files) ``` Signed-off-by: Sébastien Han --- llama_stack/providers/utils/responses/responses_store.py | 2 +- llama_stack/providers/utils/sqlstore/authorized_sqlstore.py | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/llama_stack/providers/utils/responses/responses_store.py b/llama_stack/providers/utils/responses/responses_store.py index 1b1cb66d4..ea6db7991 100644 --- a/llama_stack/providers/utils/responses/responses_store.py +++ b/llama_stack/providers/utils/responses/responses_store.py @@ -116,7 +116,7 @@ class ResponsesStore: return OpenAIResponseObjectWithInput(**row["response_object"]) async def delete_response_object(self, response_id: str) -> OpenAIDeleteResponseObject: - row = await self.sql_store.fetch_one("openai_responses", where={"id": response_id}) + row = await self.sql_store.fetch_one("openai_responses", where={"id": response_id}, policy=self.policy) if not row: raise ValueError(f"Response with id {response_id} not found") await self.sql_store.delete("openai_responses", where={"id": response_id}) diff --git a/llama_stack/providers/utils/sqlstore/authorized_sqlstore.py b/llama_stack/providers/utils/sqlstore/authorized_sqlstore.py index 520c8203b..65401382f 100644 --- a/llama_stack/providers/utils/sqlstore/authorized_sqlstore.py +++ b/llama_stack/providers/utils/sqlstore/authorized_sqlstore.py @@ -166,6 +166,10 @@ class AuthorizedSqlStore: return results.data[0] if results.data else None + async def delete(self, table: str, where: Mapping[str, Any]) -> None: + """Delete rows with automatic access control filtering.""" + await self.sql_store.delete(table, where) + def _build_access_control_where_clause(self, policy: list[AccessRule]) -> str: """Build SQL WHERE clause for access control filtering.