phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-12-03 18:00:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

chore: add storage sane defaults

Browse source 
since `StackRunConfig` requires certain parts of `StorageConfig`, it'd probably make sense to template in some defaults that will "just work" for most usecases

specifically `ServerStoresConfig` defaults for inference, metadata, conversations and prompts, which we already actually funnell in defaults for  ad-hoc throughout the codebase

additionally set some `backends` defaults for the `StorageConfig`.

This will alleviate some weirdness for `--providers` for run/list-deps and also some work I have to better align our list-deps/run datatypes

Signed-off-by: Charlie Doern <cdoern@redhat.com>
This commit is contained in:
Charlie Doern 2025-11-18 15:45:30 -05:00
parent bd5ad2963e
commit 92945f4f4d
1 changed files with 23 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

27
src/llama_stack/core/storage/datatypes.py
View file

@ -12,6 +12,8 @@ from typing import Annotated, Literal
from pydantic import BaseModel, Field, field_validator from pydantic import BaseModel, Field, field_validator
from llama_stack.core.utils.config_dirs import DISTRIBS_BASE_DIR
class StorageBackendType(StrEnum): class StorageBackendType(StrEnum):
KV_REDIS = "kv_redis" KV_REDIS = "kv_redis"
@ -256,15 +258,24 @@ class ResponsesStoreReference(InferenceStoreReference):
class ServerStoresConfig(BaseModel): class ServerStoresConfig(BaseModel):
metadata: KVStoreReference | None = Field( metadata: KVStoreReference | None = Field(
default=None, default=KVStoreReference(
backend="kv_default",
namespace="registry",
),
description="Metadata store configuration (uses KV backend)", description="Metadata store configuration (uses KV backend)",
) )
inference: InferenceStoreReference | None = Field( inference: InferenceStoreReference | None = Field(
default=None, default=InferenceStoreReference(
backend="sql_default",
table_name="inference_store",
),
description="Inference store configuration (uses SQL backend)", description="Inference store configuration (uses SQL backend)",
) )
conversations: SqlStoreReference | None = Field( conversations: SqlStoreReference | None = Field(
default=None, default=SqlStoreReference(
backend="sql_default",
table_name="openai_conversations",
),
description="Conversations store configuration (uses SQL backend)", description="Conversations store configuration (uses SQL backend)",
) )
responses: ResponsesStoreReference | None = Field( responses: ResponsesStoreReference | None = Field(
@ -272,13 +283,21 @@ class ServerStoresConfig(BaseModel):
description="Responses store configuration (uses SQL backend)", description="Responses store configuration (uses SQL backend)",
) )
prompts: KVStoreReference | None = Field( prompts: KVStoreReference | None = Field(
default=None, default=KVStoreReference(backend="kv_default", namespace="prompts"),
description="Prompts store configuration (uses KV backend)", description="Prompts store configuration (uses KV backend)",
) )
class StorageConfig(BaseModel): class StorageConfig(BaseModel):
backends: dict[str, StorageBackendConfig] = Field( backends: dict[str, StorageBackendConfig] = Field(
default={
"kv_default": SqliteKVStoreConfig(
db_path=f"${{env.SQLITE_STORE_DIR:={DISTRIBS_BASE_DIR}}}/kvstore.db",
),
"sql_default": SqliteSqlStoreConfig(
db_path=f"${{env.SQLITE_STORE_DIR:={DISTRIBS_BASE_DIR}}}/sql_store.db",
),
},
description="Named backend configurations (e.g., 'default', 'cache')", description="Named backend configurations (e.g., 'default', 'cache')",
) )
stores: ServerStoresConfig = Field( stores: ServerStoresConfig = Field(