From 93d6c1a4e6aa6730ee172c5c7d662564d8c17af2 Mon Sep 17 00:00:00 2001 From: Xi Yan Date: Mon, 28 Oct 2024 11:45:37 -0700 Subject: [PATCH] braintrust scoring identifier check, rebase --- .../providers/impls/braintrust/scoring/braintrust.py | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/llama_stack/providers/impls/braintrust/scoring/braintrust.py b/llama_stack/providers/impls/braintrust/scoring/braintrust.py index 4b1455539..3b8263dfb 100644 --- a/llama_stack/providers/impls/braintrust/scoring/braintrust.py +++ b/llama_stack/providers/impls/braintrust/scoring/braintrust.py @@ -33,7 +33,6 @@ class BraintrustScoringImpl(Scoring, ScoringFunctionsProtocolPrivate): async def initialize(self) -> None: self.braintrust_scoring_fn_impl = BraintrustScoringFn() - await self.braintrust_scoring_fn_impl.initialize() self.supported_fn_ids = { x.identifier for x in self.braintrust_scoring_fn_impl.get_supported_scoring_fn_defs() @@ -45,7 +44,16 @@ class BraintrustScoringImpl(Scoring, ScoringFunctionsProtocolPrivate): assert ( self.braintrust_scoring_fn_impl is not None ), "braintrust_scoring_fn_impl is not initialized, need to call initialize for provider. " - return self.braintrust_scoring_fn_impl.get_supported_scoring_fn_defs() + scoring_fn_defs_list = ( + self.braintrust_scoring_fn_impl.get_supported_scoring_fn_defs() + ) + + for f in scoring_fn_defs_list: + assert f.identifier.startswith( + "braintrust" + ), "All braintrust scoring fn must have identifier prefixed with 'braintrust'! " + + return scoring_fn_defs_list async def register_scoring_function(self, function_def: ScoringFnDef) -> None: raise NotImplementedError(