phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-10-03 19:57:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat: use FIPS validated CSPRNG for telemetry (#3554)
Some checks failed
SqlStore Integration Tests / test-postgres (3.12) (push) Failing after 0s
Details
Test External Providers Installed via Module / test-external-providers-from-module (venv) (push) Has been skipped
Details
Integration Tests (Replay) / Integration Tests (, , , client=, ) (push) Failing after 3s
Details
Python Package Build Test / build (3.13) (push) Failing after 2s
Details
SqlStore Integration Tests / test-postgres (3.13) (push) Failing after 19s
Details
API Conformance Tests / check-schema-compatibility (push) Successful in 8s
Details
Test External API and Providers / test-external (venv) (push) Failing after 3s
Details
Unit Tests / unit-tests (3.12) (push) Failing after 3s
Details
Integration Auth Tests / test-matrix (oauth2_token) (push) Failing after 17s
Details
Unit Tests / unit-tests (3.13) (push) Failing after 14s
Details
Vector IO Integration Tests / test-matrix (push) Failing after 18s
Details
Python Package Build Test / build (3.12) (push) Failing after 18s
Details
UI Tests / ui-tests (22) (push) Successful in 53s
Details
Pre-commit / pre-commit (push) Successful in 1m14s
Details

Browse source 
# What does this PR do?
Switches from `random.getrandbits` to `secrets.randbits` in the
telemetry module.

<!-- If resolving an issue, uncomment and update the line below -->
Closes #3553 

## Test Plan
Unit tests from scripts/unit-tests.sh were ran to verify the tests still
pass.

Signed-off-by: Doug Edgar <dedgar@redhat.com>
This commit is contained in:
Doug Edgar 2025-09-26 02:17:25 -07:00 • committed by GitHub
parent 28d83faf8a
commit 9c751b6789
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
llama_stack/providers/utils/telemetry/tracing.py
View file

@ -8,7 +8,7 @@ import asyncio
import contextvars
import logging # allow-direct-logging
import queue
import random
import secrets
import sys
import threading
import time
@ -76,16 +76,16 @@ def span_id_to_str(span_id: int) -> str:
def generate_span_id() -> str:
span_id = random.getrandbits(64)
span_id = secrets.randbits(64)
while span_id == INVALID_SPAN_ID:
span_id = random.getrandbits(64)
span_id = secrets.randbits(64)
return span_id_to_str(span_id)
def generate_trace_id() -> str:
trace_id = random.getrandbits(128)
trace_id = secrets.randbits(128)
while trace_id == INVALID_TRACE_ID:
trace_id = random.getrandbits(128)
trace_id = secrets.randbits(128)
return trace_id_to_str(trace_id)