phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-10-05 20:27:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Address review comments for global vector store configuration

Browse source 
- Remove incorrect 'Llama-Stack v2' version reference from documentation
- Move MissingEmbeddingModelError to llama_stack/apis/common/errors.py
- Update docstring references to point to correct exception location
- Clarify default_embedding_dimension behavior (defaults to 384)
- Update test imports and exception handling
This commit is contained in:
skamenan7 2025-07-30 13:40:33 -04:00
parent f9afad99f8
commit a368f4af40
4 changed files with 5 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
llama_stack/core/routers/vector_io.py
View file

@ -11,6 +11,7 @@ from typing import Any
from llama_stack.apis.common.content_types import (
InterleavedContent,
)
from llama_stack.apis.common.errors import MissingEmbeddingModelError
from llama_stack.apis.common.vector_store_config import VectorStoreConfig
from llama_stack.apis.models import ModelType
from llama_stack.apis.vector_io import (
@ -106,9 +107,6 @@ class VectorIORouter(VectorIO):
return cfg.default_embedding_model, cfg.default_embedding_dimension or 384
# 3. error - no default
class MissingEmbeddingModelError(RuntimeError):
pass
raise MissingEmbeddingModelError(
"Failed to create vector store: No embedding model provided. Set vector_store_config.default_embedding_model or supply one in the API call."
)