phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-07-18 10:52:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: stop image_name from being cast to an integer (#2759)
Some checks failed
Integration Tests / discover-tests (push) Successful in 3s
Details
Vector IO Integration Tests / test-matrix (3.12, remote::pgvector) (push) Failing after 4s
Details
Python Package Build Test / build (3.12) (push) Failing after 3s
Details
Integration Auth Tests / test-matrix (oauth2_token) (push) Failing after 9s
Details
Vector IO Integration Tests / test-matrix (3.13, inline::faiss) (push) Failing after 8s
Details
Integration Tests / test-matrix (push) Failing after 4s
Details
Python Package Build Test / build (3.13) (push) Failing after 7s
Details
Vector IO Integration Tests / test-matrix (3.12, inline::faiss) (push) Failing after 13s
Details
Vector IO Integration Tests / test-matrix (3.13, remote::chromadb) (push) Failing after 10s
Details
Vector IO Integration Tests / test-matrix (3.12, inline::milvus) (push) Failing after 12s
Details
Vector IO Integration Tests / test-matrix (3.12, inline::sqlite-vec) (push) Failing after 12s
Details
Unit Tests / unit-tests (3.12) (push) Failing after 8s
Details
Vector IO Integration Tests / test-matrix (3.12, remote::chromadb) (push) Failing after 13s
Details
Test External Providers / test-external-providers (venv) (push) Failing after 9s
Details
Vector IO Integration Tests / test-matrix (3.13, inline::milvus) (push) Failing after 13s
Details
Vector IO Integration Tests / test-matrix (3.13, inline::sqlite-vec) (push) Failing after 12s
Details
Vector IO Integration Tests / test-matrix (3.13, remote::pgvector) (push) Failing after 12s
Details
Unit Tests / unit-tests (3.13) (push) Failing after 10s
Details
SqlStore Integration Tests / test-postgres (3.12) (push) Failing after 18s
Details
Update ReadTheDocs / update-readthedocs (push) Failing after 40s
Details
SqlStore Integration Tests / test-postgres (3.13) (push) Failing after 51s
Details
Pre-commit / pre-commit (push) Successful in 2m1s
Details

Browse source 
# What does this PR do?

https://github.com/meta-llama/llama-stack/pull/2490 introduced a new
function for type conversion of strings.

However, a side effect of this is that it will cast any string that can
be cast to an integer if possible, which for something like `image_name`
is not desired as we only accept strings for this field in the
`StackRunConfig`

This PR introduces logic to ensure that `image_name` remains a string 

Closes #2749

## Test Plan

You can run the original step to reproduce from the bug to verify this
manually
```bash
OPENAI_API_KEY=bogus llama stack build --image-type venv --image-name 2745 --providers inference=remote::openai --run
```

I have also added an additional unit test to prevent any future
regression here

Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
This commit is contained in:
Nathan Weinberg 2025-07-15 12:44:21 -04:00 • committed by GitHub
parent 31b088978a
commit b3d86ca926
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 50 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
llama_stack/distribution/configure.py
View file

@ -17,7 +17,7 @@ from llama_stack.distribution.distribution import (
builtin_automatically_routed_apis,
get_provider_registry,
)
from llama_stack.distribution.stack import replace_env_vars
from llama_stack.distribution.stack import cast_image_name_to_string, replace_env_vars
from llama_stack.distribution.utils.config_dirs import EXTERNAL_PROVIDERS_DIR
from llama_stack.distribution.utils.dynamic import instantiate_class_type
from llama_stack.distribution.utils.prompt_for_config import prompt_for_config
@ -164,7 +164,8 @@ def upgrade_from_routing_table(
def parse_and_maybe_upgrade_config(config_dict: dict[str, Any]) -> StackRunConfig:
version = config_dict.get("version", None)
if version == LLAMA_STACK_RUN_CONFIG_VERSION:
return StackRunConfig(**replace_env_vars(config_dict))
processed_config_dict = replace_env_vars(config_dict)
return StackRunConfig(**cast_image_name_to_string(processed_config_dict))
if "routing_table" in config_dict:
logger.info("Upgrading config...")
@ -175,4 +176,5 @@ def parse_and_maybe_upgrade_config(config_dict: dict[str, Any]) -> StackRunConfi
if not config_dict.get("external_providers_dir", None):
config_dict["external_providers_dir"] = EXTERNAL_PROVIDERS_DIR
return StackRunConfig(**replace_env_vars(config_dict))
processed_config_dict = replace_env_vars(config_dict)
return StackRunConfig(**cast_image_name_to_string(processed_config_dict))