From b6954c9882d1f10c3dacd5062701dd9a857dbd67 Mon Sep 17 00:00:00 2001 From: Nathan Weinberg <31703736+nathan-weinberg@users.noreply.github.com> Date: Mon, 27 Oct 2025 16:41:38 -0400 Subject: [PATCH] fix: add missing shutdown methods to PromptServiceImpl and ConversationServiceImpl (#3925) Change is visible in server shutdown logs, changes `WARNING` loglines to `INFO` Signed-off-by: Nathan Weinberg --- src/llama_stack/core/conversations/conversations.py | 3 +++ src/llama_stack/core/prompts/prompts.py | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/llama_stack/core/conversations/conversations.py b/src/llama_stack/core/conversations/conversations.py index 83a49e848..951de5e9d 100644 --- a/src/llama_stack/core/conversations/conversations.py +++ b/src/llama_stack/core/conversations/conversations.py @@ -312,3 +312,6 @@ class ConversationServiceImpl(Conversations): logger.debug(f"Deleted item {item_id} from conversation {conversation_id}") return ConversationItemDeletedResource(id=item_id) + + async def shutdown(self) -> None: + pass diff --git a/src/llama_stack/core/prompts/prompts.py b/src/llama_stack/core/prompts/prompts.py index 1e48bcc8c..1a6f38cb5 100644 --- a/src/llama_stack/core/prompts/prompts.py +++ b/src/llama_stack/core/prompts/prompts.py @@ -230,3 +230,6 @@ class PromptServiceImpl(Prompts): await self.kvstore.set(default_key, str(version)) return self._deserialize_prompt(data) + + async def shutdown(self) -> None: + pass