From ba1d50c67b70c2338fa8534665c5442a321f49ed Mon Sep 17 00:00:00 2001 From: Xi Yan Date: Tue, 12 Nov 2024 10:29:25 -0500 Subject: [PATCH] naming fix --- llama_stack/providers/inline/scoring/basic/scoring.py | 4 ++-- .../providers/inline/scoring/llm_as_judge/scoring.py | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/llama_stack/providers/inline/scoring/basic/scoring.py b/llama_stack/providers/inline/scoring/basic/scoring.py index 6632d5b81..98803ae4a 100644 --- a/llama_stack/providers/inline/scoring/basic/scoring.py +++ b/llama_stack/providers/inline/scoring/basic/scoring.py @@ -34,8 +34,8 @@ class BasicScoringImpl(Scoring, ScoringFunctionsProtocolPrivate): self.scoring_fn_id_impls = {} async def initialize(self) -> None: - for x in FIXED_FNS: - impl = x() + for fn in FIXED_FNS: + impl = fn() for fn_defs in impl.get_supported_scoring_fn_defs(): self.scoring_fn_id_impls[fn_defs.identifier] = impl diff --git a/llama_stack/providers/inline/scoring/llm_as_judge/scoring.py b/llama_stack/providers/inline/scoring/llm_as_judge/scoring.py index b20a189b1..0cb81e114 100644 --- a/llama_stack/providers/inline/scoring/llm_as_judge/scoring.py +++ b/llama_stack/providers/inline/scoring/llm_as_judge/scoring.py @@ -40,8 +40,8 @@ class LlmAsJudgeScoringImpl(Scoring, ScoringFunctionsProtocolPrivate): self.scoring_fn_id_impls = {} async def initialize(self) -> None: - for x in LLM_JUDGE_FNS: - impl = x(inference_api=self.inference_api) + for fn in LLM_JUDGE_FNS: + impl = fn(inference_api=self.inference_api) for fn_defs in impl.get_supported_scoring_fn_defs(): self.scoring_fn_id_impls[fn_defs.identifier] = impl self.llm_as_judge_fn = impl @@ -58,7 +58,7 @@ class LlmAsJudgeScoringImpl(Scoring, ScoringFunctionsProtocolPrivate): for f in scoring_fn_defs_list: assert f.identifier.startswith( "llm-as-judge" - ), "All meta-reference scoring fn must have identifier prefixed with 'meta-reference'! " + ), "All llm-as-judge scoring fn must have identifier prefixed with 'llm-as-judge'! " return scoring_fn_defs_list