From bbd40d8cc4d4b4f3a070072485f04be2466d2d00 Mon Sep 17 00:00:00 2001 From: Ashwin Bharambe Date: Thu, 16 Oct 2025 06:43:17 -0700 Subject: [PATCH] fixes --- llama_stack/core/store/registry.py | 3 --- llama_stack/providers/utils/inference/openai_mixin.py | 2 +- tests/unit/providers/utils/inference/test_openai_mixin.py | 4 ++-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/llama_stack/core/store/registry.py b/llama_stack/core/store/registry.py index cb06f6a57..04581bab5 100644 --- a/llama_stack/core/store/registry.py +++ b/llama_stack/core/store/registry.py @@ -102,9 +102,6 @@ class DiskDistributionRegistry(DistributionRegistry): "Unregister it first if you want to replace it." ) - if "sentence-transformers/sentence-transformers" in obj.identifier: - raise Exception("OMG") - await self.kvstore.set( KEY_FORMAT.format(type=obj.type, identifier=obj.identifier), obj.model_dump_json(), diff --git a/llama_stack/providers/utils/inference/openai_mixin.py b/llama_stack/providers/utils/inference/openai_mixin.py index 9469308c2..dc397aa76 100644 --- a/llama_stack/providers/utils/inference/openai_mixin.py +++ b/llama_stack/providers/utils/inference/openai_mixin.py @@ -435,7 +435,7 @@ class OpenAIMixin(NeedsRequestProviderData, ABC, BaseModel): """ # First check if the model is pre-registered in the model store if hasattr(self, "model_store") and self.model_store: - qualified_model = f"{self.__provider_id__}/{model}" + qualified_model = f"{self.__provider_id__}/{model}" # type: ignore[attr-defined] if await self.model_store.has_model(qualified_model): return True diff --git a/tests/unit/providers/utils/inference/test_openai_mixin.py b/tests/unit/providers/utils/inference/test_openai_mixin.py index 80c219055..78241bc22 100644 --- a/tests/unit/providers/utils/inference/test_openai_mixin.py +++ b/tests/unit/providers/utils/inference/test_openai_mixin.py @@ -205,7 +205,7 @@ class TestOpenAIMixinCheckModelAvailability: assert await mixin.check_model_availability("pre-registered-model") # Should not call the provider's list_models since model was found in store mock_client_with_models.models.list.assert_not_called() - mock_model_store.has_model.assert_called_once_with("pre-registered-model") + mock_model_store.has_model.assert_called_once_with("test-provider/pre-registered-model") async def test_check_model_availability_fallback_to_provider_when_not_in_store( self, mixin, mock_client_with_models, mock_client_context @@ -222,7 +222,7 @@ class TestOpenAIMixinCheckModelAvailability: assert await mixin.check_model_availability("some-mock-model-id") # Should call the provider's list_models since model was not found in store mock_client_with_models.models.list.assert_called_once() - mock_model_store.has_model.assert_called_once_with("some-mock-model-id") + mock_model_store.has_model.assert_called_once_with("test-provider/some-mock-model-id") class TestOpenAIMixinCacheBehavior: