phoenix-oss/llama-stack-mirror
0
0
Fork 1
mirror of https://github.com/meta-llama/llama-stack.git synced 2025-12-15 18:32:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

address comments

Browse source
This commit is contained in:
Xi Yan 2024-10-22 14:13:00 -07:00
parent 95aef814af
commit bd39b22717
7 changed files with 25 additions and 45 deletions
Download patch file Download diff file Expand all files Collapse all files

4
llama_stack/apis/datasetio/datasetio.py
View file

@ -17,7 +17,7 @@ class PaginatedRowsResult(BaseModel):
# the rows obey the DatasetSchema for the given dataset
rows: List[Dict[str, Any]]
total_count: int
next_page_token: Optional[int] = None
next_page_token: Optional[str] = None
class DatasetStore(Protocol):
@ -34,6 +34,6 @@ class DatasetIO(Protocol):
self,
dataset_id: str,
rows_in_page: int,
page_token: Optional[int] = None,
page_token: Optional[str] = None,
filter_condition: Optional[str] = None,
) -> PaginatedRowsResult: ...

6
llama_stack/apis/datasets/datasets.py
View file

@ -50,11 +50,5 @@ class Datasets(Protocol):
dataset_identifier: str,
) -> Optional[DatasetDefWithProvider]: ...
@webmethod(route="/datasets/delete")
async def delete_dataset(
self,
dataset_identifier: str,
) -> None: ...
@webmethod(route="/datasets/list", method="GET")
async def list_datasets(self) -> List[DatasetDefWithProvider]: ...