address comments

This commit is contained in:
Xi Yan 2024-10-22 14:13:00 -07:00
parent 95aef814af
commit bd39b22717
7 changed files with 25 additions and 45 deletions

View file

@ -17,7 +17,7 @@ class PaginatedRowsResult(BaseModel):
# the rows obey the DatasetSchema for the given dataset
rows: List[Dict[str, Any]]
total_count: int
next_page_token: Optional[int] = None
next_page_token: Optional[str] = None
class DatasetStore(Protocol):
@ -34,6 +34,6 @@ class DatasetIO(Protocol):
self,
dataset_id: str,
rows_in_page: int,
page_token: Optional[int] = None,
page_token: Optional[str] = None,
filter_condition: Optional[str] = None,
) -> PaginatedRowsResult: ...