fix faiss db health check correctly via review

tests/unit/providers/vector_io/test_faiss.py

@@ -11,9 +11,11 @@ import numpy as np
 import pytest
 import pytest_asyncio
 
+from llama_stack.apis.files import Files
 from llama_stack.apis.inference import EmbeddingsResponse, Inference
 from llama_stack.apis.vector_dbs import VectorDB
 from llama_stack.apis.vector_io import Chunk, QueryChunksResponse
+from llama_stack.providers.datatypes import HealthStatus
 from llama_stack.providers.inline.vector_io.faiss.config import FaissVectorIOConfig
 from llama_stack.providers.inline.vector_io.faiss.faiss import (
     FaissIndex,
@@ -76,6 +78,12 @@ def mock_inference_api(sample_embeddings):
     return mock_api
 
 
+@pytest.fixture
+def mock_files_api():
+    mock_api = MagicMock(spec=Files)
+    return mock_api
+
+
 @pytest.fixture
 def faiss_config():
     config = MagicMock(spec=FaissVectorIOConfig)
@@ -90,11 +98,19 @@ async def faiss_index(embedding_dimension):
 
 
 @pytest_asyncio.fixture
-async def faiss_adapter(faiss_config, mock_inference_api) -> FaissVectorIOAdapter:
-    adapter = FaissVectorIOAdapter(config=faiss_config, inference_api=mock_inference_api)
-    await adapter.initialize()
-    yield adapter
-    await adapter.shutdown()
+async def faiss_adapter(faiss_config, mock_inference_api, mock_files_api) -> FaissVectorIOAdapter:
+    # Create the adapter
+    adapter = FaissVectorIOAdapter(config=faiss_config, inference_api=mock_inference_api, files_api=mock_files_api)
+
+    # Create a mock KVStore
+    mock_kvstore = MagicMock()
+    mock_kvstore.values_in_range = AsyncMock(return_value=[])
+
+    # Patch the initialize method to avoid the kvstore_impl call
+    with patch.object(FaissVectorIOAdapter, "initialize"):
+        # Set the kvstore directly
+        adapter.kvstore = mock_kvstore
+        yield adapter
 
 
 @pytest.mark.asyncio
@@ -118,3 +134,49 @@ async def test_faiss_query_vector_returns_infinity_when_query_and_embedding_are_
 
         assert response.chunks[0] == sample_chunks[0]
         assert response.chunks[1] == sample_chunks[1]
+
+
+@pytest.mark.asyncio
+async def test_health_success():
+    """Test that the health check returns OK status when faiss is working correctly."""
+    # Create a fresh instance of FaissVectorIOAdapter for testing
+    config = MagicMock()
+    inference_api = MagicMock()
+    files_api = MagicMock()
+
+    with patch("llama_stack.providers.inline.vector_io.faiss.faiss.faiss.IndexFlatL2") as mock_index_flat:
+        mock_index_flat.return_value = MagicMock()
+        adapter = FaissVectorIOAdapter(config=config, inference_api=inference_api, files_api=files_api)
+
+        # Calling the health method directly
+        response = await adapter.health()
+
+        # Verifying the response
+        assert isinstance(response, dict)
+        assert response["status"] == HealthStatus.OK
+        assert "message" not in response
+
+        # Verifying that IndexFlatL2 was called with the correct dimension
+        mock_index_flat.assert_called_once_with(128)  # VECTOR_DIMENSION is 128
+
+
+@pytest.mark.asyncio
+async def test_health_failure():
+    """Test that the health check returns ERROR status when faiss encounters an error."""
+    # Create a fresh instance of FaissVectorIOAdapter for testing
+    config = MagicMock()
+    inference_api = MagicMock()
+    files_api = MagicMock()
+
+    with patch("llama_stack.providers.inline.vector_io.faiss.faiss.faiss.IndexFlatL2") as mock_index_flat:
+        mock_index_flat.side_effect = Exception("Test error")
+
+        adapter = FaissVectorIOAdapter(config=config, inference_api=inference_api, files_api=files_api)
+
+        # Calling the health method directly
+        response = await adapter.health()
+
+        # Verifying the response
+        assert isinstance(response, dict)
+        assert response["status"] == HealthStatus.ERROR
+        assert response["message"] == "Health check failed: Test error"